www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.learn - Re: Error building dfl on dmd 2.054

reply Jesse Phillips <jessekphillips+D gmail.com> writes:
Jesse Phillips Wrote:

 I just made a pull request to fix this in the unofficial repo. But
Bearophile's alias is probably the correct solution.

Forgot to give you the quick link: https://github.com/Rayerd/dfl/pull/3
Jul 26 2011
parent reply simendsjo <simendsjo gmail.com> writes:
On 26.07.2011 20:49, Jesse Phillips wrote:
 Jesse Phillips Wrote:

 I just made a pull request to fix this in the unofficial repo. But
Bearophile's alias is probably the correct solution.

Forgot to give you the quick link: https://github.com/Rayerd/dfl/pull/3

!? Now I'm a bit lost. It says that repo is unofficial. The SVN repo seems alive as it was last updated a couple of months ago.
Jul 26 2011
parent reply Jesse Phillips <jessekphillips+d gmail.com> writes:
On Tue, 26 Jul 2011 22:22:39 +0200, simendsjo wrote:

 On 26.07.2011 20:49, Jesse Phillips wrote:
 Jesse Phillips Wrote:

 I just made a pull request to fix this in the unofficial repo. But
 Bearophile's alias is probably the correct solution.

Forgot to give you the quick link: https://github.com/Rayerd/dfl/pull/3

!? Now I'm a bit lost. It says that repo is unofficial. The SVN repo seems alive as it was last updated a couple of months ago.

The author is maintaining it. But there was a good time while it didn't compile with the latest and so a published fix was made. As to whether there was an attempted patch submission, I don't know. But I'm going with github because it is damn easy to contribute, and publicize work sooner than a review process allows. It would be interesting if Christopher forked his project and continued working from github (its not like he doesn't get the credit).
Jul 26 2011
parent reply simendsjo <simendsjo gmail.com> writes:
On 27.07.2011 03:30, Jesse Phillips wrote:
 On Tue, 26 Jul 2011 22:22:39 +0200, simendsjo wrote:

 On 26.07.2011 20:49, Jesse Phillips wrote:
 Jesse Phillips Wrote:

 I just made a pull request to fix this in the unofficial repo. But
 Bearophile's alias is probably the correct solution.

Forgot to give you the quick link: https://github.com/Rayerd/dfl/pull/3

!? Now I'm a bit lost. It says that repo is unofficial. The SVN repo seems alive as it was last updated a couple of months ago.

The author is maintaining it. But there was a good time while it didn't compile with the latest and so a published fix was made. As to whether there was an attempted patch submission, I don't know. But I'm going with github because it is damn easy to contribute, and publicize work sooner than a review process allows. It would be interesting if Christopher forked his project and continued working from github (its not like he doesn't get the credit).

I agree github is a much better collaboration platform than dsource+svn, but C.Miller should at least be contacted. It's bad for a project to get fragmented if it doesn't have to be. Off to try the github version then.
Jul 27 2011
next sibling parent simendsjo <simendsjo gmail.com> writes:
On 27.07.2011 09:47, simendsjo wrote:
 On 27.07.2011 03:30, Jesse Phillips wrote:
 On Tue, 26 Jul 2011 22:22:39 +0200, simendsjo wrote:

 On 26.07.2011 20:49, Jesse Phillips wrote:
 Jesse Phillips Wrote:

 I just made a pull request to fix this in the unofficial repo. But
 Bearophile's alias is probably the correct solution.

Forgot to give you the quick link: https://github.com/Rayerd/dfl/pull/3

!? Now I'm a bit lost. It says that repo is unofficial. The SVN repo seems alive as it was last updated a couple of months ago.

The author is maintaining it. But there was a good time while it didn't compile with the latest and so a published fix was made. As to whether there was an attempted patch submission, I don't know. But I'm going with github because it is damn easy to contribute, and publicize work sooner than a review process allows. It would be interesting if Christopher forked his project and continued working from github (its not like he doesn't get the credit).

I agree github is a much better collaboration platform than dsource+svn, but C.Miller should at least be contacted. It's bad for a project to get fragmented if it doesn't have to be. Off to try the github version then.

Worked great, thanks! And yes, github is better. I removed the warnings and added a pull request. Go github.
Jul 27 2011
prev sibling parent Jesse Phillips <jessekphillips+D gmail.com> writes:
simendsjo Wrote:

 I agree github is a much better collaboration platform than dsource+svn, 
 but C.Miller should at least be contacted. It's bad for a project to get 
 fragmented if it doesn't have to be.
 
 Off to try the github version then.
 

I'm pretty sure I contacted him to find out what to do with my ini updates, but never heard from him, but I used his contact form and so don't have a record of it or know if it went through.
Jul 27 2011