www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.learn - A Quesiton for Mr. Adam Ruppe Regarding arsd.dom

reply Somebody <somebody somebody.somebody> writes:
Greetings,

I decided to use the arsd.dom library for a project, but I 
noticed that one of my tests was failing when comparing the 
expected data to the parsed data. Turns out arsd.dom's 
parseEntity function did not handle the entities that were in the 
document being parsed. I'm assuming that parseEntity only works 
with so many entities to reduce bloat, and modifying the function 
is trivial, but it's still a minor inconvenience due to having to 
manage my own fork. Out of curiosity, do you plan to add more 
handled entities in the future, or is the current amount deemed 
okay?

Thanks,
...

P.S. I'm very grateful for your work!
Dec 15 2019
parent reply Adam D. Ruppe <destructionator gmail.com> writes:
On Sunday, 15 December 2019 at 21:16:16 UTC, Somebody wrote:
 I'm assuming that parseEntity only works with so many entities 
 to reduce bloat
Some of it is just because I was too lazy to add it all. I basically just added the entities I encountered when I was using it for work a while ago. I'm always willing to add more as needed though. If you sent me a pull request with more I'd probably accept it without hesitation.
Dec 15 2019
parent reply Somebody <somebody somebody.somebody> writes:
On Monday, 16 December 2019 at 00:13:42 UTC, Adam D. Ruppe wrote:
 On Sunday, 15 December 2019 at 21:16:16 UTC, Somebody wrote:
 I'm assuming that parseEntity only works with so many entities 
 to reduce bloat
Some of it is just because I was too lazy to add it all. I basically just added the entities I encountered when I was using it for work a while ago. I'm always willing to add more as needed though. If you sent me a pull request with more I'd probably accept it without hesitation.
Do you mind if I send you a patch via email? According to Github, I don't have an email address with a "trustworthy" domain. Thanks, ...
Dec 15 2019
parent reply Adam D. Ruppe <destructionator gmail.com> writes:
On Monday, 16 December 2019 at 02:36:40 UTC, Somebody wrote:
 Do you mind if I send you a patch via email? According to 
 Github, I don't have an email address with a "trustworthy" 
 domain.
no problem at all, i have accepted a few email patches in there already :) destructionator gmail.com ill check the spam box in the morning too to ensure i actually get it (I also have a secret email that has no spam filter but i can't post it here, if needed tho i can reply with it)
Dec 15 2019
parent Somebody <somebody somebody.somebody> writes:
On Monday, 16 December 2019 at 02:41:57 UTC, Adam D. Ruppe wrote:
 On Monday, 16 December 2019 at 02:36:40 UTC, Somebody wrote:
 Do you mind if I send you a patch via email? According to 
 Github, I don't have an email address with a "trustworthy" 
 domain.
no problem at all, i have accepted a few email patches in there already :) destructionator gmail.com ill check the spam box in the morning too to ensure i actually get it (I also have a secret email that has no spam filter but i can't post it here, if needed tho i can reply with it)
That's good to hear. I was a bit worried I'd be a bother. The patch should be in your inbox, or most likely your spambox, by now. If it isn't, please let me know. Thanks, ...
Dec 15 2019