• Johan Engelen (14/14) Dec 28 2017 Hi all,
• David Nadlinger (2/3) Dec 28 2017 Let's kill it – it's clearly outlived its use. —David
• Johan Engelen (3/7) Dec 29 2017 https://github.com/ldc-developers/ldc/pull/2476

Johan Engelen <j j.nl> writes:

Hi all,
   Is the #define "LDC_WITH_PGO" still needed?

IIRC, I added it originally because back then we supported LLVM 
3.5 too, which did not have PGO. Now that we start support from 
LLVM3.7, this is no longer an issue.
Except that it needs runtime support and perhaps compiler-rt 
doesn't have profile support on all our platforms. But then still 
it is OK to compile LDC with PGO support, just the runtime 
library may be missing. In our CMakeLists.txt it is set to True 
per default.

It'd be nice to get rid of it, for a little nicer reading of 
code. Not a big deal though.

Cheers,
   Johan

"David Nadlinger" <code klickverbot.at> writes:

On 29 Dec 2017, at 1:45, Johan Engelen via digitalmars-d-ldc wrote:
   Is the #define "LDC_WITH_PGO" still needed?

Let's kill it – it's clearly outlived its use. —David

Johan Engelen <j j.nl> writes:

On Friday, 29 December 2017 at 00:53:23 UTC, David Nadlinger 
wrote:
 On 29 Dec 2017, at 1:45, Johan Engelen via digitalmars-d-ldc 
 wrote:
   Is the #define "LDC_WITH_PGO" still needed?

 Let's kill it – it's clearly outlived its use. —David

https://github.com/ldc-developers/ldc/pull/2476