• d-bugmail puremagic.com (32/32) Mar 28 2012 http://d.puremagic.com/issues/show_bug.cgi?id=7790
• d-bugmail puremagic.com (10/10) Dec 05 2012 http://d.puremagic.com/issues/show_bug.cgi?id=7790
• d-bugmail puremagic.com (11/11) Dec 06 2012 http://d.puremagic.com/issues/show_bug.cgi?id=7790
• d-bugmail puremagic.com (9/9) Dec 06 2012 http://d.puremagic.com/issues/show_bug.cgi?id=7790
• d-bugmail puremagic.com (11/11) Apr 18 2013 http://d.puremagic.com/issues/show_bug.cgi?id=7790
• d-bugmail puremagic.com (11/11) Apr 18 2013 http://d.puremagic.com/issues/show_bug.cgi?id=7790

d-bugmail puremagic.com writes:

http://d.puremagic.com/issues/show_bug.cgi?id=7790

           Summary: [CTFE] assignment to AA apply ref argument
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: dawg dawgfoto.de


--- Comment #0 from dawg dawgfoto.de 2012-03-28 22:11:30 PDT ---
struct Symbol
{
    size_t _id;
}

size_t foo(Symbol[string] tree)
{
    size_t i;
    foreach(k, ref v; tree)
        v._id = ++i; // has no effect
    return tree["a"]._id;
}

static assert(foo(["a":Symbol(0)]) == 1);

--------

The assignment to the ref value field has no effect.
Looks like the value literal is copied before calling the
foreach body.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

d-bugmail puremagic.com writes:

http://d.puremagic.com/issues/show_bug.cgi?id=7790


Don <clugdbug yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull, wrong-code


--- Comment #1 from Don <clugdbug yahoo.com.au> 2012-12-05 23:53:44 PST ---
https://github.com/D-Programming-Language/dmd/pull/1351

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

d-bugmail puremagic.com writes:

http://d.puremagic.com/issues/show_bug.cgi?id=7790



--- Comment #2 from github-bugzilla puremagic.com 2012-12-06 06:28:50 PST ---
Commit pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/93a019d5b10dc0fdc207912d8311a7498bad0e6b
Fix issue 7790 [CTFE] assignment to AA apply ref argument

1. IndexExp: Stop copying the AA whenever it is indexed (This was horrific for
performance, as well as being wrong).
2. aaApply: If the value is 'ref', create a reference to the value.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

d-bugmail puremagic.com writes:

http://d.puremagic.com/issues/show_bug.cgi?id=7790


dawg dawgfoto.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

d-bugmail puremagic.com writes:

http://d.puremagic.com/issues/show_bug.cgi?id=7790



--- Comment #3 from github-bugzilla puremagic.com 2013-04-18 11:22:58 PDT ---
Commit pushed to dmd-1.x at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/c42dcec4f053ffa65feb278d09efb701fabc6fa0
Fix issue 7790 [CTFE] assignment to AA apply ref argument

1. IndexExp: Stop copying the AA whenever it is indexed (This was horrific for
performance, as well as being wrong).
2. aaApply: If the value is 'ref', create a reference to the value.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

d-bugmail puremagic.com writes:

http://d.puremagic.com/issues/show_bug.cgi?id=7790


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla digitalmars.com
            Version|D2                          |D1 & D2


--- Comment #4 from Walter Bright <bugzilla digitalmars.com> 2013-04-18
11:32:20 PDT ---
https://github.com/D-Programming-Language/dmd/pull/1908

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------