digitalmars.D.bugs - [Issue 6066] New: std.container: BinaryHeap interface is broken.
- d-bugmail puremagic.com (30/30) May 28 2011 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (10/10) May 28 2011 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (6/6) Jan 07 2013 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (10/10) Jan 08 2013 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (11/11) Jan 08 2013 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (11/11) Jan 08 2013 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (11/11) Feb 11 2013 http://d.puremagic.com/issues/show_bug.cgi?id=6066
- d-bugmail puremagic.com (10/10) Feb 11 2013 http://d.puremagic.com/issues/show_bug.cgi?id=6066
http://d.puremagic.com/issues/show_bug.cgi?id=6066
Summary: std.container: BinaryHeap interface is broken.
Product: D
Version: D2
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Phobos
AssignedTo: nobody puremagic.com
ReportedBy: timon.gehr gmx.ch
From my code:
auto h=BinaryHeap!(typeof(s),"a.y<b.y")(s);
The two argument's order is reverse: the compiler can always infer the type but
hardly the comparison predicate.
That the "convenience function" heapify does not take an optional comparison
predicate does not make things any better.
Ideally, it should be possible to write:
auto h=heapify!"a.y<b.y"(s);
(As is consistent with Eg. sort.)
Therefore:
1. Ideally, the order of the two arguments for BinaryHeap should change.
2. heapify _really_ should take a comparison predicate as its first template
argument. This won't break code, because no sane D developer has explicitly
passed the type to heapify.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 28 2011
d-bugmail puremagic.com
http://d.puremagic.com/issues/show_bug.cgi?id=6066
Andrei Alexandrescu <andrei metalanguage.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |andrei metalanguage.com
AssignedTo|nobody puremagic.com |andrei metalanguage.com
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 28 2011
http://d.puremagic.com/issues/show_bug.cgi?id=6066 PST --- https://github.com/D-Programming-Language/phobos/pull/1057 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Jan 07 2013
http://d.puremagic.com/issues/show_bug.cgi?id=6066
Alex Rønne Petersen <alex lycus.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
CC| |alex lycus.org
Resolution| |FIXED
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 08 2013
http://d.puremagic.com/issues/show_bug.cgi?id=6066
timon.gehr gmx.ch changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
That does not fix the problem.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 08 2013
http://d.puremagic.com/issues/show_bug.cgi?id=6066
timon.gehr gmx.ch changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
Oops. I misread. It fixes 2. That is probably good enough.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 08 2013
http://d.puremagic.com/issues/show_bug.cgi?id=6066 Commits pushed to staging at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/2a87eded137499f5180609f58f53dc697c06a272 Issue 6066 - std.container: BinaryHeap interface is broken. https://github.com/D-Programming-Language/phobos/commit/1878535f96885825ad5dddf53670a632c244dc24 Issue 6066 - std.container: BinaryHeap interface is broken. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 11 2013
http://d.puremagic.com/issues/show_bug.cgi?id=6066 Commits pushed to https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/2a87eded137499f5180609f58f53dc697c06a272 Issue 6066 - std.container: BinaryHeap interface is broken. https://github.com/D-Programming-Language/phobos/commit/1878535f96885825ad5dddf53670a632c244dc24 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 11 2013