digitalmars.D.bugs - [Issue 4953] New: opBinaryRight for "in" doesn't work right
- d-bugmail puremagic.com (38/38) Sep 28 2010 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (11/11) Sep 29 2010 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (28/35) Sep 30 2010 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (16/16) Sep 30 2010 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (14/14) Sep 30 2010 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (11/11) Oct 05 2010 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (13/13) Jul 12 2011 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (11/12) Jul 21 2011 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (7/11) Jul 21 2011 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (10/10) Aug 28 2011 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (26/26) Sep 25 2011 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (14/14) Feb 19 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (21/21) Mar 19 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (10/10) Mar 24 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (13/13) May 12 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (9/12) May 12 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (13/13) May 12 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (9/9) May 12 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (9/9) May 12 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
- d-bugmail puremagic.com (10/10) Jul 10 2012 http://d.puremagic.com/issues/show_bug.cgi?id=4953
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Summary: opBinaryRight for "in" doesn't work right
Product: D
Version: D2
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: DMD
AssignedTo: nobody puremagic.com
ReportedBy: schveiguy yahoo.com
14:13:57 PDT ---
Given this struct:
struct S
{
short _x;
bool opBinaryRight(string op)(short x) if (op == "in")
{
return x == _x;
}
}
void main()
{
S s;
5 in s;
}
This produces the error:
testopin.d(13): Error: rvalue of in expression must be an associative array,
not S
But change the type of x to int, and it works. However, the type of the
argument should play no role in whether the template can be instantiated. It
seems this is the error message that is given when a type does not support
opIn, so the error message is very bad too.
Slightly related, but not the same issue: bug 3905
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 28 2010
d-bugmail puremagic.com
http://d.puremagic.com/issues/show_bug.cgi?id=4953
06:06:21 PDT ---
Further evidence, this compiles:
void main()
{
S s;
s.opBinaryRight!"in"(5);
}
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 29 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Don <clugdbug yahoo.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rejects-valid
CC| |clugdbug yahoo.com.au
Summary|opBinaryRight for "in" |opBinary, opBinaryRight
|doesn't work right |don't do implicit
| |conversion properly
Further evidence, this compiles:
void main()
{
S s;
s.opBinaryRight!"in"(5);
}
This is not specific to "in". The code below fails to compile, but it works if
you change "short" to "int".
struct S
{
void opBinary(string op)(short x)
{}
}
void main()
{
S s;
s + 5;
}
Original title for this bug was:
opBinaryRight for "in" doesn't work right
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 30 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Wow. This is a lot more general than I thought. Consider this code:
void foo(T = void)(short x) {}
void main()
{
foo(5);
}
This compiled in 2.030, failed in 2.031 and later.
However, if you change 'short' to 'long', it works.
It's because of mtype.c, TypeBasic::implicitConvTo(), line 3010.
Implicit conversion to a smaller size is disallowed. That's fine in general,
but shouldn't be true of template deduction.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 30 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4953
bearophile_hugs eml.cc changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bearophile_hugs eml.cc
Another example:
void foo(T = void)(short x) {}
void main() {
foo(5_000_000);
}
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 30 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Don <clugdbug yahoo.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|opBinary, opBinaryRight |Regression(2.031):
|don't do implicit |templates don't do implicit
|conversion properly |conversion properly
Severity|normal |regression
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 05 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4953
yebblies <yebblies gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |patch
CC| |yebblies gmail.com
Platform|Other |All
OS/Version|Linux |All
https://github.com/D-Programming-Language/dmd/pull/239
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 12 2011
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Walter Bright <bugzilla digitalmars.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bugzilla digitalmars.com
18:09:50 PDT ---
https://github.com/D-Programming-Language/dmd/pull/239
The patch breaks the test suite.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 21 2011
http://d.puremagic.com/issues/show_bug.cgi?id=4953Redone: https://github.com/D-Programming-Language/dmd/pull/269 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------https://github.com/D-Programming-Language/dmd/pull/239The patch breaks the test suite.
Jul 21 2011
http://d.puremagic.com/issues/show_bug.cgi?id=4953
yebblies <yebblies gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |k.hara.pg gmail.com
*** Issue 6567 has been marked as a duplicate of this issue. ***
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 28 2011
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Erik Baklund <ebaklund hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ebaklund hotmail.com
---
Yet another example:
module main;
struct MyStruct
{
void funOpAssign(float[1u] data) { }
void opOpAssign(string op)(float[1u] data) if(op=="<<") { }
}
int main(string[] argv)
{
// dmd v2.054, v2.055
MyStruct s;
float[1u] a = [1.0f]; // OK: Implicit cast from float[] compiles
s.funOpAssign([1.0f]); // OK: Implicit cast from float[] compiles
s <<= [1.0f]; // Issue: Implicit cast from float[] does not compile
s <<= cast(float[1u])[1.0f]; // OK: Explicit cast from float[] compiles
return 0;
}
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 25 2011
http://d.puremagic.com/issues/show_bug.cgi?id=4953
yebblies <yebblies gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|pull |
AssignedTo|nobody puremagic.com |bugzilla digitalmars.com
The pull is still valid (if in need of a rebase) but the solution needs a
decision from Walter on how the match level problem is going to be solved in
the future.
See issue 2367 for another example.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 19 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953
hsteoh quickfur.ath.cx changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hsteoh quickfur.ath.cx
Another data point:
void f(dstring d) { dstring e = d; }
f("abc"); // OK
void f()(dstring d) { dstring e = d; }
f("abc"); // OK
void f(byte[] b) { byte[] c = b; }
f([1,2,3]); // OK
void f()(byte[] b) { byte[] c = b; }
f([1,2,3]);
// Error: template test2.f() does not match any function template declaration
// Error: template test2.f() cannot deduce template function from argument
types !()(int[])
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Mar 19 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Kenji Hara <k.hara.pg gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |pull
---
https://github.com/D-Programming-Language/dmd/pull/45
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Mar 24 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Brad Roberts <braddr puremagic.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|pull |
CC| |braddr puremagic.com
PDT ---
Looking at this history of this bug and the pulls in github, it looks like
there isn't a valid pull request that fixes this bug right now. Removing the
keyword.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 12 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953 ---Looking at this history of this bug and the pulls in github, it looks like there isn't a valid pull request that fixes this bug right now. Removing the keyword.My dmd/pull/45 fixes both bug 5896 and this. I think the two bugs need the changes of each other. Please keep 'pull' keyword. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 12 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Brad Roberts <braddr puremagic.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |pull
PDT ---
I'll add it back, but it looked like Walter was rejecting the pull request. It
is still open, so might as well leave them linked.
Walter, would you put regression pull requests such as this one near the top of
your todo list? Either reject with reasons or pull. Limbo sucks.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 12 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953 Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/91093c7bb19b2f43dffa868c5f8125e1bd347412 fix Issue 4953 - Regression(2.031): templates don't do implicit conversion properly -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 12 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953
Walter Bright <bugzilla digitalmars.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 12 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4953
yebblies <yebblies gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |timon.gehr gmx.ch
*** Issue 7366 has been marked as a duplicate of this issue. ***
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 10 2012