digitalmars.D.bugs - [Issue 10048] New: TypeInfo comparison allocates memory
- d-bugmail puremagic.com (24/24) May 08 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10048
- d-bugmail puremagic.com (12/14) May 09 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10048
- d-bugmail puremagic.com (10/13) May 10 2013 http://d.puremagic.com/issues/show_bug.cgi?id=10048
http://d.puremagic.com/issues/show_bug.cgi?id=10048 Summary: TypeInfo comparison allocates memory Product: D Version: D2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: druntime AssignedTo: nobody puremagic.com ReportedBy: code dawg.eu The current implementation of TypeInfo.opEquals is very naive. It calls TypeInfo.toString on both operands and compares the resulting strings. The main problem is that this allocates memory for each comparison. Another issue is that it may result in false positive comparisons, e.g. when comparing .classinfo of a class and it's updated version. related: https://github.com/D-Programming-Language/druntime/pull/370 https://github.com/D-Programming-Language/druntime/pull/438 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 08 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10048 Benjamin Thaut <code benjamin-thaut.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code benjamin-thaut.de PDT ---Another issue is that it may result in false positive comparisons, e.g. when comparing .classinfo of a class and it's updated version.Why is this a false positive? Thats exactly the behavior you want when reloading changed classes at runtime. You want the new reloaded class to take the place of the old one without anything breaking. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 09 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10048Why is this a false positive? Thats exactly the behavior you want when reloading changed classes at runtime. You want the new reloaded class to take the place of the old one without anything breaking.Because the classinfos might have different vtables and initializers, therefor they should not compare equal. This becomes crucial if you have to deal with both types at the same time. If you want to hotswap an instance you have to serialize and reinstantiate it. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 10 2013