www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Waste of computing resources in pull requests that only change the

reply BBasile <b2.temp gmx.com> writes:
I don't know If it's a known problem but auto tester resources 
are lost by PR that only change or add DDOC comments. For example 
whole dmd+runtime+phobos can be rebuild 3 times per day on 8 
machines while it's not necessary.

I understand that's a side-effect of the doc being directly in 
the code, but...

Wouldn't be possible to run a background tool, based on 
libdparse, that
- detects changed lines in the diff.
- run the libdparse-based tool to see if changed lines are only 
in the ddoc.

Depending on the results, either only CyberShadow's doc builder 
would run or also the big auto-tester.
Mar 04 2016
next sibling parent reply Seb <seb wilzba.ch> writes:
On Friday, 4 March 2016 at 09:03:43 UTC, BBasile wrote:

 I don't know If it's a known problem but auto tester resources 
 are lost by PR that only change or add DDOC comments. For 
 example whole dmd+runtime+phobos can be rebuild 3 times per day 
 on 8 machines while it's not necessary.

 I understand that's a side-effect of the doc being directly in 
 the code, but...

 Wouldn't be possible to run a background tool, based on 
 libdparse, that
 - detects changed lines in the diff.
 - run the libdparse-based tool to see if changed lines are only 
 in the ddoc.

 Depending on the results, either only CyberShadow's doc builder 
 would run or also the big auto-tester.


I totally agree that this is a problem, but sometimes there are 
weird side effects, e.g.

https://github.com/D-Programming-Language/phobos/pull/4049

(it does change a bit more than just ddoc though)
Mar 04 2016
parent reply BBasile <b2.temp gmx.com> writes:
On Friday, 4 March 2016 at 09:36:03 UTC, Seb wrote:

 On Friday, 4 March 2016 at 09:03:43 UTC, BBasile wrote:

 [...]


 I totally agree that this is a problem, but sometimes there are 
 weird side effects, e.g.

 https://github.com/D-Programming-Language/phobos/pull/4049

 (it does change a bit more than just ddoc though)


This case should be detected by the tool.
Mar 04 2016
parent BBasile <b2.temp gmx.com> writes:
On Friday, 4 March 2016 at 10:04:19 UTC, BBasile wrote:

 On Friday, 4 March 2016 at 09:36:03 UTC, Seb wrote:

 On Friday, 4 March 2016 at 09:03:43 UTC, BBasile wrote:

 [...]


 I totally agree that this is a problem, but sometimes there 
 are weird side effects, e.g.

 https://github.com/D-Programming-Language/phobos/pull/4049

 (it does change a bit more than just ddoc though)


 This case should be detected by the tool.


without problem...it adds a "Unittest".
( 
https://github.com/Hackerpilot/libdparse/blob/3257b3c905127e8bccf4b9b2ebc50b9b448c0fba/s
c/dparse/ast.d#L330 )
Mar 04 2016
prev sibling next sibling parent reply Vladimir Panteleev <thecybershadow.lists gmail.com> writes:
On Friday, 4 March 2016 at 09:03:43 UTC, BBasile wrote:

 Wouldn't be possible to run a background tool, based on


Good luck getting any changes into the autotester at this point.

https://github.com/D-Programming-Language/druntime/pull/960
Mar 04 2016
next sibling parent BBasile <b2.temp gmx.com> writes:
On Friday, 4 March 2016 at 09:55:09 UTC, Vladimir Panteleev wrote:

 On Friday, 4 March 2016 at 09:03:43 UTC, BBasile wrote:

 Wouldn't be possible to run a background tool, based on


 Good luck getting any changes into the autotester at this point.

 https://github.com/D-Programming-Language/druntime/pull/960


Ah, I see, there's more important at this point. That's true that 
DMD64 for win is still not officially distributed.
Mar 04 2016
prev sibling parent Johannes Pfau <nospam example.com> writes:
Am Fri, 04 Mar 2016 09:55:09 +0000
schrieb Vladimir Panteleev <thecybershadow.lists gmail.com>:


 On Friday, 4 March 2016 at 09:03:43 UTC, BBasile wrote:

 Wouldn't be possible to run a background tool, based on  


 
 Good luck getting any changes into the autotester at this point.
 
 https://github.com/D-Programming-Language/druntime/pull/960
 


I guess a nice GSOC project would be setting up a custom travis CI
installation for ci.dlang.org & all compilers :-)
AFAICS all travis CI source code is available, so it should be
possible. OTOH it looks like nobody has done this before and there's
no documentation...
Mar 04 2016
prev sibling parent Brad Roberts via Digitalmars-d <digitalmars-d puremagic.com> writes:
It wouldn't be very difficult to add an "ignore me please" sort of flag 
on pull requests, but ignoring the ddoc only change subset of pulls 
would only have a minor overall impact on tester coverage.  By _far_, 
the bigger issue is the number of open pull requests as a whole. 
There's currently 270 open pull requests between the three repositories 
(dmd, druntime, and phobos).

By design, the tester re-tests every open pull request in most recently 
updated order after every merge.

If you want to help the D project, the best way to do so right now, 
imho, is code reviews and getting pulls merged or closed.

On 3/4/2016 1:03 AM, BBasile via Digitalmars-d wrote:

 I don't know If it's a known problem but auto tester resources are lost
 by PR that only change or add DDOC comments. For example whole
 dmd+runtime+phobos can be rebuild 3 times per day on 8 machines while
 it's not necessary.

 I understand that's a side-effect of the doc being directly in the code,
 but...

 Wouldn't be possible to run a background tool, based on libdparse, that
 - detects changed lines in the diff.
 - run the libdparse-based tool to see if changed lines are only in the
 ddoc.

 Depending on the results, either only CyberShadow's doc builder would
 run or also the big auto-tester.
Mar 04 2016