• Vladiwostok (28/28) Oct 13 Greetings,

Vladiwostok <riciuvlad gmail.com> writes:

Greetings,

I've fixed Autofix for StaticIfElse:
https://github.com/Dlang-UPB/D-scanner/pull/157

I've also almost finished Autofix for FunctionAttributeCheck, 
there's an edge case left which adds an additional attribute on 
an interface function:
https://github.com/Dlang-UPB/D-scanner/pull/156

I've also fixed  nolint for the 3 checks that had this feature 
implemented:
https://github.com/Dlang-UPB/D-scanner/pull/158
Unfortunately the existing nolint code could not be salvaged as 
it relies heavily on the libdparse AST.

There are a few PRs unable to be merged due to an issue with unit 
test source code formatting on Windows OS + dub, which seems 
related to the last week's issue. Last week additional blank 
lines were added in the source code. I wasn't able to reproduce 
the issue on my Windows machine, nor was I able to establish an 
SSH connection to a Windows machine used in the testing pipeline. 
Razvan & Edi helped with a fix by changing the delimiters used 
for delimited strings:
https://github.com/Dlang-UPB/D-scanner/commit/d99ada25815b74f19496d038d1d108c944956aa7#diff-d4c37ebbd7d9a4ae39cc7ada0f03a58e29532e0fb9c07a47e709bb4ba0c0c2fbR111-R149
The pipeline on Windows + makefile succeeds, on Windows + dub 
does not. It fails due to differences found when computing file 
offsets. I'm wondering if anybody had a similar issue and has any 
thoughts on this.

PRs in talk:
https://github.com/Dlang-UPB/D-scanner/pull/157
https://github.com/Dlang-UPB/D-scanner/pull/151