• =?UTF-8?Q?S=c3=b6nke_Ludwig?= (9/9) Apr 18 2016 This is a rather important pull request and the last big milestone for
• Marc =?UTF-8?B?U2Now7x0eg==?= (3/13) Apr 19 2016 Link:
• =?UTF-8?Q?S=c3=b6nke_Ludwig?= (2/16) Apr 19 2016 Thanks, totally forgot to do that...
• Jack Stouffer (5/10) Apr 19 2016 Having a huge mix of doc changes and functionality changes, even
• =?UTF-8?Q?S=c3=b6nke_Ludwig?= (3/11) Apr 19 2016 There are (almost) no functionality changes. Code is just moved to other...
• Sebastiaan Koppe (2/12) Apr 19 2016 LGTM

=?UTF-8?Q?S=c3=b6nke_Ludwig?= <sludwig outerproduct.org> writes:

This is a rather important pull request and the last big milestone for 
the 1.0.0 release. I'd like to get the next version out shortly, but 
this PR is sitting idle for over a month now and partially blocks 
development.

It consists of mostly just documentation additions, deprecations/name 
changes and moved code, so the review can focus on the high level 
changes and should be well manageable despite the size of the diff 
(commit-by-commit review is a good idea, though).

Any support is much appreciated!

Marc =?UTF-8?B?U2Now7x0eg==?= <schuetzm gmx.net> writes:

On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
 This is a rather important pull request and the last big 
 milestone for the 1.0.0 release. I'd like to get the next 
 version out shortly, but this PR is sitting idle for over a 
 month now and partially blocks development.

 It consists of mostly just documentation additions, 
 deprecations/name changes and moved code, so the review can 
 focus on the high level changes and should be well manageable 
 despite the size of the diff (commit-by-commit review is a good 
 idea, though).

 Any support is much appreciated!

Link:
https://github.com/dlang/dub/pull/785

=?UTF-8?Q?S=c3=b6nke_Ludwig?= <sludwig outerproduct.org> writes:

Am 19.04.2016 um 11:44 schrieb Marc Schütz:
 On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
 This is a rather important pull request and the last big milestone for
 the 1.0.0 release. I'd like to get the next version out shortly, but
 this PR is sitting idle for over a month now and partially blocks
 development.

 It consists of mostly just documentation additions, deprecations/name
 changes and moved code, so the review can focus on the high level
 changes and should be well manageable despite the size of the diff
 (commit-by-commit review is a good idea, though).

 Any support is much appreciated!

 Link:
 https://github.com/dlang/dub/pull/785

Thanks, totally forgot to do that...

Jack Stouffer <jack jackstouffer.com> writes:

On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
 It consists of mostly just documentation additions, 
 deprecations/name changes and moved code, so the review can 
 focus on the high level changes and should be well manageable 
 despite the size of the diff (commit-by-commit review is a good 
 idea, though).

Having a huge mix of doc changes and functionality changes, even 
if you review commit by commit, is pretty hard to review. I think 
it would be easier for people to help with this if this was 
multiple PRs.

=?UTF-8?Q?S=c3=b6nke_Ludwig?= <sludwig outerproduct.org> writes:

Am 19.04.2016 um 18:50 schrieb Jack Stouffer:
 On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
 It consists of mostly just documentation additions, deprecations/name
 changes and moved code, so the review can focus on the high level
 changes and should be well manageable despite the size of the diff
 (commit-by-commit review is a good idea, though).

 Having a huge mix of doc changes and functionality changes, even if you
 review commit by commit, is pretty hard to review. I think it would be
 easier for people to help with this if this was multiple PRs.

There are (almost) no functionality changes. Code is just moved to other 
modules in some cases.

Sebastiaan Koppe <mail skoppe.eu> writes:

On Tuesday, 19 April 2016 at 06:31:13 UTC, Sönke Ludwig wrote:
 This is a rather important pull request and the last big 
 milestone for the 1.0.0 release. I'd like to get the next 
 version out shortly, but this PR is sitting idle for over a 
 month now and partially blocks development.

 It consists of mostly just documentation additions, 
 deprecations/name changes and moved code, so the review can 
 focus on the high level changes and should be well manageable 
 despite the size of the diff (commit-by-commit review is a good 
 idea, though).

 Any support is much appreciated!

LGTM