• Manu via Digitalmars-d (7/7) Oct 01 2016 Unsigned case is:
• safety0ff (2/6) Oct 01 2016 https://forum.dlang.org/post/nfkaag$2d6u$1@digitalmars.com
• Andrei Alexandrescu (4/11) Oct 01 2016 The intent is to return 0 when the input is 0. Looking at
• Walter Bright (3/16) Oct 01 2016 Interestingly, this is one of the few algorithms that can be tested with...
• Manu via Digitalmars-d (14/28) Oct 01 2016 Yeah, I feel that's probably sub-optimal, but I haven't tried to solve

Manu via Digitalmars-d <digitalmars-d puremagic.com> writes:

Unsigned case is:
  return (x & -x) > (x - 1);

Wouldn't this be better:
  return (sz & (sz-1)) == 0;

I also don't understand the integer promotion and recursive call in
the integer case. Can someone explain how the std.math implementation
is ideal?

safety0ff <safety0ff.dev gmail.com> writes:

On Sunday, 2 October 2016 at 03:05:37 UTC, Manu wrote:
 Unsigned case is:
   return (x & -x) > (x - 1);

 Wouldn't this be better:
   return (sz & (sz-1)) == 0;

https://forum.dlang.org/post/nfkaag$2d6u$1 digitalmars.com

Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:

On 10/01/2016 11:05 PM, Manu via Digitalmars-d wrote:
 Unsigned case is:
   return (x & -x) > (x - 1);

 Wouldn't this be better:
   return (sz & (sz-1)) == 0;

 I also don't understand the integer promotion and recursive call in
 the integer case. Can someone explain how the std.math implementation
 is ideal?

The intent is to return 0 when the input is 0. Looking at 
https://github.com/dlang/phobos/blob/master/std/math.d, the 
implementation for signed integers might be simplified a bit. -- Andrei

Walter Bright <newshound2 digitalmars.com> writes:

On 10/1/2016 8:46 PM, Andrei Alexandrescu wrote:
 On 10/01/2016 11:05 PM, Manu via Digitalmars-d wrote:
 Unsigned case is:
   return (x & -x) > (x - 1);

 Wouldn't this be better:
   return (sz & (sz-1)) == 0;

 I also don't understand the integer promotion and recursive call in
 the integer case. Can someone explain how the std.math implementation
 is ideal?

 The intent is to return 0 when the input is 0. Looking at
 https://github.com/dlang/phobos/blob/master/std/math.d, the implementation for
 signed integers might be simplified a bit. -- Andrei

Interestingly, this is one of the few algorithms that can be tested with an 
exhaustive test of all possibilities!

Manu via Digitalmars-d <digitalmars-d puremagic.com> writes:

On 2 October 2016 at 13:46, Andrei Alexandrescu via Digitalmars-d
<digitalmars-d puremagic.com> wrote:
 On 10/01/2016 11:05 PM, Manu via Digitalmars-d wrote:
 Unsigned case is:
   return (x & -x) > (x - 1);

 Wouldn't this be better:
   return (sz & (sz-1)) == 0;

 I also don't understand the integer promotion and recursive call in
 the integer case. Can someone explain how the std.math implementation
 is ideal?


 The intent is to return 0 when the input is 0. Looking at
 https://github.com/dlang/phobos/blob/master/std/math.d, the implementation
 for signed integers might be simplified a bit. -- Andrei

Yeah, I feel that's probably sub-optimal, but I haven't tried to solve
with that case in mind.
I have a feeling that if you have to handle x == 0, then it might be
possible to make the signed and unsigned cases identical... it smells
like there's a '>' in there in that case, which should be able to
eliminate negative cases aswell as the 0 case.

I'm not sure this is written in a way where, if you're able to
convince the optimiser that x > 0, that the optimiser is able to
eliminate the unnecessary work.
It's pretty easy to convince the optimiser of valid value ranges, and
in the case you demonstrate x > 0, it should empower the optimiser to
produce the most efficient version.