www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - std.hash: Ready for review (review manager needed)

reply Johannes Pfau <nospam example.com> writes:
I think std.hash is ready for review now. I'm not sure if any other
module in the review queue is ready, but as there was no clear response
in the last review thread I assume we can start the std.hash review.

We still need a review manager though.

---------------
std.hash.hash is a new module for Phobos providing a
uniform interface for hashes and checksums. It also provides some
useful helper functions to deal with this new API.

The std.hash package also includes a md5 implementation deprecating
std.md5 (in std.hash.md, adapted from std.md5), a new SHA1
implementation by redstar (in std.hash.sha) and a CRC32 implementation
(in std.hash.crc) based on and deprecating the crc32 module that's
shipped with phobos but not documented.

It only covers hashes which can process data incrementally (in
smaller buffers as opposed to all data at once).

Code:
https://github.com/jpf91/phobos/tree/newHash/std/hash
https://github.com/jpf91/phobos/compare/master...newHash

Docs:
http://dl.dropbox.com/u/24218791/d/phobos/std_hash_hash.html
http://dl.dropbox.com/u/24218791/d/phobos/std_hash_md.html
http://dl.dropbox.com/u/24218791/d/phobos/std_hash_sha.html
http://dl.dropbox.com/u/24218791/d/phobos/std_hash_crc.html
Aug 06 2012
parent Dmitry Olshansky <dmitry.olsh gmail.com> writes:
On 06-Aug-12 14:36, Johannes Pfau wrote:
 I think std.hash is ready for review now. I'm not sure if any other
 module in the review queue is ready, but as there was no clear response
 in the last review thread I assume we can start the std.hash review.

 We still need a review manager though.

Hm, I almost missed this post :) If anything I'm ready to manage another review. Let's start it tomorrow if nobody pops up with a ready to go module that was sitting in the queue longer.
 ---------------
 std.hash.hash is a new module for Phobos providing a
 uniform interface for hashes and checksums. It also provides some
 useful helper functions to deal with this new API.

 The std.hash package also includes a md5 implementation deprecating
 std.md5 (in std.hash.md, adapted from std.md5), a new SHA1
 implementation by redstar (in std.hash.sha) and a CRC32 implementation
 (in std.hash.crc) based on and deprecating the crc32 module that's
 shipped with phobos but not documented.

 It only covers hashes which can process data incrementally (in
 smaller buffers as opposed to all data at once).

 Code:
 https://github.com/jpf91/phobos/tree/newHash/std/hash
 https://github.com/jpf91/phobos/compare/master...newHash

 Docs:
 http://dl.dropbox.com/u/24218791/d/phobos/std_hash_hash.html
 http://dl.dropbox.com/u/24218791/d/phobos/std_hash_md.html
 http://dl.dropbox.com/u/24218791/d/phobos/std_hash_sha.html
 http://dl.dropbox.com/u/24218791/d/phobos/std_hash_crc.html

-- Dmitry Olshansky
Aug 06 2012