www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.dwt - DWT2 now looks working on Windows (except Text widget doesn't support

reply Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
About month ago I fixed some DWT2 bugs, but DWT maintainers just have no 
time to pull changes to the main repo. Changes are in my (denis_sh) 
commits descriptions:
https://bitbucket.org/denis_sh/patching-dwt2

Short changes description:
1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not 
worse): lots of segfaults when printing and text editing and other bugs.
2. It looks working stable on Windows except Text widget sill doesn't 
support UTF-8 (yes, StyledText and it's friend now support it).
3. It now have compilable and right snippets.
Aug 03 2011
next sibling parent reply Jacob Carlborg <doob me.com> writes:
On 2011-08-03 22:02, Denis Shelomovskij wrote:
 About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
 time to pull changes to the main repo. Changes are in my (denis_sh)
 commits descriptions:
 https://bitbucket.org/denis_sh/patching-dwt2

I'm so sorry. I haven't prioritized DWT and I've forgotten pull requests and patches in tickets. I will look into this. Maybe I can move the repository to bitbucket or github, this will make it easier creating and merging pull requests.
 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
 worse): lots of segfaults when printing and text editing and other bugs.
 2. It looks working stable on Windows except Text widget sill doesn't
 support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

That's great, at least someone is working on DWT. -- /Jacob Carlborg
Aug 03 2011
next sibling parent reply Jesse Phillips <jessekphillips+d gmail.com> writes:
On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:

 I'm so sorry. I haven't prioritized DWT and I've forgotten pull requests
 and patches in tickets. I will look into this. Maybe I can move the
 repository to bitbucket or github, this will make it easier creating and
 merging pull requests.

I'm bias toward Git, I'm really liking submodules.
 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1
 (not worse): lots of segfaults when printing and text editing and other
 bugs. 2. It looks working stable on Windows except Text widget sill
 doesn't support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

That's great, at least someone is working on DWT.

Yes, very good news.
Aug 04 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-08-04 16:16, Jesse Phillips wrote:
 On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:

 I'm so sorry. I haven't prioritized DWT and I've forgotten pull requests
 and patches in tickets. I will look into this. Maybe I can move the
 repository to bitbucket or github, this will make it easier creating and
 merging pull requests.

I'm bias toward Git, I'm really liking submodules.

I like both git and github more than mercurial and bitbucket. Many seem to switch to github for their D development; DMD, Phobos Druntime; all of them are now on github. But on the other hand the DWT repository is already a mercurial repository and there are several forks on bitbucket.
 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1
 (not worse): lots of segfaults when printing and text editing and other
 bugs. 2. It looks working stable on Windows except Text widget sill
 doesn't support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

That's great, at least someone is working on DWT.

Yes, very good news.

-- /Jacob Carlborg
Aug 04 2011
parent reply Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
05.08.2011 9:38, Jacob Carlborg пишет:
 On 2011-08-04 16:16, Jesse Phillips wrote:
 On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:

 I'm so sorry. I haven't prioritized DWT and I've forgotten pull requests
 and patches in tickets. I will look into this. Maybe I can move the
 repository to bitbucket or github, this will make it easier creating and
 merging pull requests.

I'm bias toward Git, I'm really liking submodules.

I like both git and github more than mercurial and bitbucket. Many seem to switch to github for their D development; DMD, Phobos Druntime; all of them are now on github. But on the other hand the DWT repository is already a mercurial repository and there are several forks on bitbucket.

Why? IMHO hg is better than git (newer program that fixed issues of older git and svn). Maybe github is convenient but it isn't because of git. It's a big shortcoming of github not to support hg.
Aug 05 2011
parent reply Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
 Actually, that is completely false. Git and HG were released within a
 month of eachother, have very similar feature sets, and didn't really
 influence eachother during development. Github is exclusively for Git,
 and Bitbucket is exclusively for Mercurial because you can't really mix
 them at all.
 It's a matter of taste, not a matter of "fixed issues." They're
 different programs built at the same time to accomplish the same goals.

I don't use SCM often. IMHO, SCM should just work. HG is simplier than Git (not only IMHO). So, it's a Git issue (for me) not to be as simple as HG.
Aug 05 2011
parent reply torhu <no spam.invalid> writes:
On 05.08.2011 14:00, Denis Shelomovskij wrote:
 Actually, that is completely false. Git and HG were released within
 a month of eachother, have very similar feature sets, and didn't
 really influence eachother during development. Github is
 exclusively for Git, and Bitbucket is exclusively for Mercurial
 because you can't really mix them at all. It's a matter of taste,
 not a matter of "fixed issues." They're different programs built at
 the same time to accomplish the same goals.

I don't use SCM often. IMHO, SCM should just work. HG is simplier than Git (not only IMHO). So, it's a Git issue (for me) not to be as simple as HG.

Another thing in Mercurial's favor is that it's not made and maintained by people who couldn't care less about Windows.
Aug 05 2011
parent Jacob Carlborg <doob me.com> writes:
On 2011-08-05 19:12, Andrew Wiley wrote:
 On Fri, Aug 5, 2011 at 9:10 AM, torhu <no spam.invalid> wrote:

     On 05.08.2011 14:00, Denis Shelomovskij wrote:

             Actually, that is completely false. Git and HG were released
             within
             a month of eachother, have very similar feature sets, and didn't
             really influence eachother during development. Github is
             exclusively for Git, and Bitbucket is exclusively for Mercurial
             because you can't really mix them at all. It's a matter of
             taste,
             not a matter of "fixed issues." They're different programs
             built at
             the same time to accomplish the same goals.


         I don't use SCM often. IMHO, SCM should just work. HG is simplier
         than Git (not only IMHO). So, it's a Git issue (for me) not to be as
         simple as HG.


     Another thing in Mercurial's favor is that it's not made and maintained
     by people who couldn't care less about Windows.


 In my experience, that hasn't made any difference. The Mercurial folks
 recommend TortoiseHG, and there's also TortoiseGit with the same feature
 set. I use Eclipse with DDT for most of my development, and there's
 MercurialEclipse and EGit.

If I recall correctly TortoiseGit didn't work that well when I used it. -- /Jacob Carlborg
Aug 07 2011
prev sibling next sibling parent Andrew Wiley <wiley.andrew.j gmail.com> writes:
--90e6ba6135a8ed41ec04a9be002a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 5, 2011 at 2:23 AM, Denis Shelomovskij <
verylonglogin.reg gmail.com> wrote:

 05.08.2011 9:38, Jacob Carlborg =D0=BF=D0=B8=D1=88=D0=B5=D1=82:

  On 2011-08-04 16:16, Jesse Phillips wrote:
 On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:

  I'm so sorry. I haven't prioritized DWT and I've forgotten pull reques=



 and patches in tickets. I will look into this. Maybe I can move the
 repository to bitbucket or github, this will make it easier creating a=




 merging pull requests.

I'm bias toward Git, I'm really liking submodules.

I like both git and github more than mercurial and bitbucket. Many seem to switch to github for their D development; DMD, Phobos Druntime; all of them are now on github. But on the other hand the DWT repository is already a mercurial repository and there are several forks on bitbucket.

Why? IMHO hg is better than git (newer program that fixed issues of older git and svn). Maybe github is convenient but it isn't because of git. It'=

 big shortcoming of github not to support hg.

Actually, that is completely false. Git and HG were released within a month of eachother, have very similar feature sets, and didn't really influence eachother during development. Github is exclusively for Git, and Bitbucket is exclusively for Mercurial because you can't really mix them at all. It's a matter of taste, not a matter of "fixed issues." They're different programs built at the same time to accomplish the same goals. --90e6ba6135a8ed41ec04a9be002a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <br><br><div class=3D"gmail_quote">On Fri, Aug 5, 2011 at 2:23 AM, Denis Sh= elomovskij <span dir=3D"ltr">&lt;<a href=3D"mailto:verylonglogin.reg gmail.= com">verylonglogin.reg gmail.com</a>&gt;</span> wrote:<br><blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex;"> 05.08.2011 9:38, Jacob Carlborg =D0=BF=D0=B8=D1=88=D0=B5=D1=82:<div class= =3D"im"><br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> On 2011-08-04 16:16, Jesse Phillips wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:<br> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I&#39;m so sorry. I haven&#39;t prioritized DWT and I&#39;ve forgotten pull= requests<br> and patches in tickets. I will look into this. Maybe I can move the<br> repository to bitbucket or github, this will make it easier creating and<br=

</blockquote> <br> I&#39;m bias toward Git, I&#39;m really liking submodules.<br> </blockquote> <br> I like both git and github more than mercurial and bitbucket. Many seem<br> to switch to github for their D development; DMD, Phobos Druntime; all<br> of them are now on github. But on the other hand the DWT repository is<br> already a mercurial repository and there are several forks on bitbucket.<br=

<br> <br></div> Why? IMHO hg is better than git (newer program that fixed issues of older g= it and svn). Maybe github is convenient but it isn&#39;t because of git. It= &#39;s a big shortcoming of github not to support hg.<br> </blockquote></div><br><div>Actually, that is completely false. Git and HG = were released within a month of eachother, have very similar feature sets, = and didn&#39;t really influence eachother during development. Github is exc= lusively for Git, and Bitbucket is exclusively for Mercurial because you ca= n&#39;t really mix them at all.</div> <div>It&#39;s a matter of taste, not a matter of &quot;fixed issues.&quot; = They&#39;re different programs built at the same time to accomplish the sam= e goals.</div> --90e6ba6135a8ed41ec04a9be002a--
Aug 05 2011
prev sibling next sibling parent Jesse Phillips <jessekphillips+d gmail.com> writes:
On Fri, 05 Aug 2011 08:38:55 +0200, Jacob Carlborg wrote:


 I like both git and github more than mercurial and bitbucket. Many seem
 to switch to github for their D development; DMD, Phobos Druntime; all
 of them are now on github. But on the other hand the DWT repository is
 already a mercurial repository and there are several forks on bitbucket.

You are right, there are a number of them: https://bitbucket.org/kntroh/dwt2-with-d2/overview https://bitbucket.org/Extrawurst/wursts-dwt2/overview https://bitbucket.org/denis_sh/patching-dwt2/overview https://bitbucket.org/torhus/dwt2/overview Go with bitbucket.
Aug 05 2011
prev sibling next sibling parent Jesse Phillips <jessekphillips+d gmail.com> writes:
On Fri, 05 Aug 2011 15:00:37 +0300, Denis Shelomovskij wrote:

 I don't use SCM often. IMHO, SCM should just work. HG is simplier than
 Git (not only IMHO). So, it's a Git issue (for me) not to be as simple
 as HG.

I didn't use SCM much either, but then I learned git. I'm sure HG is just as easy as git init My experience with HG has been with DWT. It wasn't too hard, but I found it confusing. Later I decided to learn Git, and read about its usage from Progit. Now I find Git easier than SVN and HG, but that is only because I never took the time to learn HG.
Aug 05 2011
prev sibling next sibling parent Andrew Wiley <wiley.andrew.j gmail.com> writes:
--0016e68ea07c6179ac04a9c535dd
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Aug 5, 2011 at 9:10 AM, torhu <no spam.invalid> wrote:

 On 05.08.2011 14:00, Denis Shelomovskij wrote:

 Actually, that is completely false. Git and HG were released within
 a month of eachother, have very similar feature sets, and didn't
 really influence eachother during development. Github is
 exclusively for Git, and Bitbucket is exclusively for Mercurial
 because you can't really mix them at all. It's a matter of taste,
 not a matter of "fixed issues." They're different programs built at
 the same time to accomplish the same goals.

I don't use SCM often. IMHO, SCM should just work. HG is simplier than Git (not only IMHO). So, it's a Git issue (for me) not to be as simple as HG.

Another thing in Mercurial's favor is that it's not made and maintained by people who couldn't care less about Windows.

In my experience, that hasn't made any difference. The Mercurial folks recommend TortoiseHG, and there's also TortoiseGit with the same feature set. I use Eclipse with DDT for most of my development, and there's MercurialEclipse and EGit. --0016e68ea07c6179ac04a9c535dd Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div class=3D"gmail_quote">On Fri, Aug 5, 2011 at 9:10 AM, torhu <span dir= =3D"ltr">&lt;no spam.invalid&gt;</span> wrote:<br><blockquote class=3D"gmai= l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left= :1ex;"> <div><div></div><div class=3D"h5">On 05.08.2011 14:00, Denis Shelomovskij w= rote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"><blockquote class=3D"gmail_quote" style=3D"m= argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Actually, that is completely false. Git and HG were released within<br> a month of eachother, have very similar feature sets, and didn&#39;t<br> really influence eachother during development. Github is<br> exclusively for Git, and Bitbucket is exclusively for Mercurial<br> because you can&#39;t really mix them at all. It&#39;s a matter of taste,<b= r> not a matter of &quot;fixed issues.&quot; They&#39;re different programs bu= ilt at<br> the same time to accomplish the same goals.<br> </blockquote> <br> I don&#39;t use SCM often. IMHO, SCM should just work. HG is simplier<br> than Git (not only IMHO). So, it&#39;s a Git issue (for me) not to be as<br=

il_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-lef= t:1ex;"><div><div class=3D"h5"><blockquote class=3D"gmail_quote" style=3D"m= argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote> <br></div></div> Another thing in Mercurial&#39;s favor is that it&#39;s not made and mainta= ined<br> by people who couldn&#39;t care less about Windows.<br></blockquote><div><b= r></div><div>In my experience, that hasn&#39;t made any difference. The Mer= curial folks recommend TortoiseHG, and there&#39;s also TortoiseGit with th= e same feature set. I use Eclipse with DDT for most of my development, and = there&#39;s MercurialEclipse and EGit.</div> </div><br> --0016e68ea07c6179ac04a9c535dd--
Aug 05 2011
prev sibling next sibling parent Andrew Wiley <wiley.andrew.j gmail.com> writes:
--0016e6d433ac32680304a9c58966
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 5, 2011 at 1:36 AM, Andrew Wiley <wiley.andrew.j gmail.com>wrot=
e:

 On Fri, Aug 5, 2011 at 2:23 AM, Denis Shelomovskij <
 verylonglogin.reg gmail.com> wrote:

 05.08.2011 9:38, Jacob Carlborg =D0=BF=D0=B8=D1=88=D0=B5=D1=82:

  On 2011-08-04 16:16, Jesse Phillips wrote:
 On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:

  I'm so sorry. I haven't prioritized DWT and I've forgotten pull
 requests
 and patches in tickets. I will look into this. Maybe I can move the
 repository to bitbucket or github, this will make it easier creating
 and
 merging pull requests.

I'm bias toward Git, I'm really liking submodules.

I like both git and github more than mercurial and bitbucket. Many seem to switch to github for their D development; DMD, Phobos Druntime; all of them are now on github. But on the other hand the DWT repository is already a mercurial repository and there are several forks on bitbucket=




Why? IMHO hg is better than git (newer program that fixed issues of olde=


 git and svn). Maybe github is convenient but it isn't because of git. It=


 big shortcoming of github not to support hg.

Actually, that is completely false. Git and HG were released within a mon=

 of eachother, have very similar feature sets, and didn't really influence
 eachother during development. Github is exclusively for Git, and Bitbucke=

 is exclusively for Mercurial because you can't really mix them at all.
 It's a matter of taste, not a matter of "fixed issues." They're different
 programs built at the same time to accomplish the same goals.

Actually, it looks like you can use Mercurial with Github: https://github.com/blog/439-hg-git-mercurial-plugin Not sure if there's an equivalent go go from a Mercurial server to a Git client. --0016e6d433ac32680304a9c58966 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <br><br><div class=3D"gmail_quote">On Fri, Aug 5, 2011 at 1:36 AM, Andrew W= iley <span dir=3D"ltr">&lt;<a href=3D"mailto:wiley.andrew.j gmail.com">wile= y.andrew.j gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_qu= ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex= ;"> <div><div></div><div class=3D"h5"><br><br><div class=3D"gmail_quote">On Fri= , Aug 5, 2011 at 2:23 AM, Denis Shelomovskij <span dir=3D"ltr">&lt;<a href= =3D"mailto:verylonglogin.reg gmail.com" target=3D"_blank">verylonglogin.reg= gmail.com</a>&gt;</span> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> 05.08.2011 9:38, Jacob Carlborg =D0=BF=D0=B8=D1=88=D0=B5=D1=82:<div><br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> On 2011-08-04 16:16, Jesse Phillips wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:<br> <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I&#39;m so sorry. I haven&#39;t prioritized DWT and I&#39;ve forgotten pull= requests<br> and patches in tickets. I will look into this. Maybe I can move the<br> repository to bitbucket or github, this will make it easier creating and<br=

</blockquote> <br> I&#39;m bias toward Git, I&#39;m really liking submodules.<br> </blockquote> <br> I like both git and github more than mercurial and bitbucket. Many seem<br> to switch to github for their D development; DMD, Phobos Druntime; all<br> of them are now on github. But on the other hand the DWT repository is<br> already a mercurial repository and there are several forks on bitbucket.<br=

<br> <br></div> Why? IMHO hg is better than git (newer program that fixed issues of older g= it and svn). Maybe github is convenient but it isn&#39;t because of git. It= &#39;s a big shortcoming of github not to support hg.<br> </blockquote></div><br></div></div><div>Actually, that is completely false.= Git and HG were released within a month of eachother, have very similar fe= ature sets, and didn&#39;t really influence eachother during development. G= ithub is exclusively for Git, and Bitbucket is exclusively for Mercurial be= cause you can&#39;t really mix them at all.</div> <div>It&#39;s a matter of taste, not a matter of &quot;fixed issues.&quot; = They&#39;re different programs built at the same time to accomplish the sam= e goals.</div></blockquote><div><br></div><div>Actually, it looks like you = can use Mercurial with Github:=C2=A0<a href=3D"https://github.com/blog/439-= hg-git-mercurial-plugin">https://github.com/blog/439-hg-git-mercurial-plugi= n</a></div> <div>Not sure if there&#39;s an equivalent go go from a Mercurial server to= a Git client.</div></div><br> --0016e6d433ac32680304a9c58966--
Aug 05 2011
prev sibling parent Jesse Phillips <jessekphillips+d gmail.com> writes:
On Fri, 05 Aug 2011 10:36:02 -0700, Andrew Wiley wrote:

 Actually, it looks like you can use Mercurial with Github:
 https://github.com/blog/439-hg-git-mercurial-plugin Not sure if there's
 an equivalent go go from a Mercurial server to a Git client.

You use the same tool but it isn't as easy. Interestingly it is developed by the github staff. While I would love it to be on Github, I think it would be best to place it where people are already putting their forks. Though maybe it isn't possible to take advantage of the fork/pull request feature as they aren't "official" forks...
Aug 05 2011
prev sibling next sibling parent reply Jacob Carlborg <doob me.com> writes:
On 2011-08-03 22:02, Denis Shelomovskij wrote:
 About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
 time to pull changes to the main repo. Changes are in my (denis_sh)
 commits descriptions:
 https://bitbucket.org/denis_sh/patching-dwt2

 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
 worse): lots of segfaults when printing and text editing and other bugs.
 2. It looks working stable on Windows except Text widget sill doesn't
 support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

I've pulled your changes now. Thanks so much for your help. I can see now that a almost all snippets work. Only two crash on launch. I've not verified that all the others are working 100% correctly but it's looking really good. You've done a great job. And again, I'm so sorry it took me so long before I pulled the changes. -- /Jacob Carlborg
Aug 10 2011
next sibling parent reply torhu <no spam.invalid> writes:
On 10.08.2011 21:32, Jacob Carlborg wrote:
 On 2011-08-03 22:02, Denis Shelomovskij wrote:
  About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
  time to pull changes to the main repo. Changes are in my (denis_sh)
  commits descriptions:
  https://bitbucket.org/denis_sh/patching-dwt2

  Short changes description:
  1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
  worse): lots of segfaults when printing and text editing and other bugs.
  2. It looks working stable on Windows except Text widget sill doesn't
  support UTF-8 (yes, StyledText and it's friend now support it).
  3. It now have compilable and right snippets.

I've pulled your changes now. Thanks so much for your help. I can see now that a almost all snippets work. Only two crash on launch. I've not verified that all the others are working 100% correctly but it's looking really good. You've done a great job. And again, I'm so sorry it took me so long before I pulled the changes.

Nice to see work being done on DWT! I did notice a slight problem with changeset 121, though. The array in isDigit needs to be declared static, or it will be copied onto the heap on each call of the function. And the rest of the function could be just this line, simpler and more efficent: return c >= '0' && c <= '9' || assumeSorted(unicodeNd).contains(c); Took me a while to find assumeSorted, but it is in std.range.
Aug 11 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-08-11 14:31, torhu wrote:
 On 10.08.2011 21:32, Jacob Carlborg wrote:
 On 2011-08-03 22:02, Denis Shelomovskij wrote:
 About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
 time to pull changes to the main repo. Changes are in my (denis_sh)
 commits descriptions:
 https://bitbucket.org/denis_sh/patching-dwt2

 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
 worse): lots of segfaults when printing and text editing and other bugs.
 2. It looks working stable on Windows except Text widget sill doesn't
 support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

I've pulled your changes now. Thanks so much for your help. I can see now that a almost all snippets work. Only two crash on launch. I've not verified that all the others are working 100% correctly but it's looking really good. You've done a great job. And again, I'm so sorry it took me so long before I pulled the changes.

Nice to see work being done on DWT! I did notice a slight problem with changeset 121, though. The array in isDigit needs to be declared static, or it will be copied onto the heap on each call of the function. And the rest of the function could be just this line, simpler and more efficent: return c >= '0' && c <= '9' || assumeSorted(unicodeNd).contains(c); Took me a while to find assumeSorted, but it is in std.range.

Yeah, that really needs to be static, I'll fix it. -- /Jacob Carlborg
Aug 11 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-09-05 18:28, Andrej Mitrovic wrote:
 Hey, so why are all those snippets named by numbers? There's a bunch
 of cool snippets here: http://www.eclipse.org/swt/snippets/

Because the java files are named like that: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets
 but I can't tell whether they're already in the snippets folder in DWT
 since they're just named with numbers. I've ported a few to D, the
 porting process seems to be really simple (in fact it wouldn't be a
 bad idea to have a script to do the conversion automatically, when it
 can).

I don't know, maybe. There will always be things that the script can't automatically translate. But you are free to create a script and if it's good enough it can be added to the dwt repository.
 I've also tried to port a Browser snippet, but Browser seems to be a
 module that's only in the linux packages in dwt.

Yes, all browser related code have only been ported for linux. I have no idea if it still works or not. If I recall correctly it didn't work very well when I tried it last time. -- /Jacob Carlborg
Sep 05 2011
parent reply Sam Hu <samhudotsamhu gmail.com> writes:
Is there a latest update which can get compiled under dmd2.055 under
Windows?Thanks.
Sep 15 2011
next sibling parent Jacob Carlborg <doob me.com> writes:
On 2011-09-16 02:13, Sam Hu wrote:
 Is there a latest update which can get compiled under dmd2.055 under
Windows?Thanks.

I have not tested yet if it builds with dmd 2.055. Currently there isn't much developing going on with DWT. I will begin developing on DWT again, eventually. -- /Jacob Carlborg
Sep 15 2011
prev sibling parent reply Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
16.09.2011 3:13, Sam Hu :
 Is there a latest update which can get compiled under dmd2.055 under
Windows?Thanks.

It compiles with dmd 2.055. So what's the problem?
Sep 16 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-09-16 10:57, Denis Shelomovskij wrote:
 16.09.2011 3:13, Sam Hu :
 Is there a latest update which can get compiled under dmd2.055 under
 Windows?Thanks.

It compiles with dmd 2.055. So what's the problem?

That's good to know, thanks. -- /Jacob Carlborg
Sep 16 2011
parent reply raojm <raojm 91ne.com> writes:
DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053 DMD2.054
DMD2.055, Because of .length  type is ulong on 64Bit system.
Sep 29 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053 DMD2.054
 DMD2.055, Because of .length  type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg
Sep 29 2011
parent reply Sam Hu <samhudotsamhu gmail.com> writes:
Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053 DMD2.054
 DMD2.055, Because of .length  type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg

Oct 02 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053 DMD2.054
 DMD2.055, Because of .length  type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg
Oct 02 2011
parent reply Sam Hu <samhudotsamhu gmail.com> writes:
Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053 DMD2.054
 DMD2.055, Because of .length  type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

Oct 06 2011
parent reply Jacob Carlborg <doob me.com> writes:
On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053 DMD2.054
 DMD2.055, Because of .length  type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg


It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket -- /Jacob Carlborg
Oct 06 2011
parent reply Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
07.10.2011 9:19, Jacob Carlborg пишет:
 On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053
 DMD2.054
 DMD2.055, Because of .length type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

widget,say Chinese characters?

It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket

About win32 version: widgets.Text doesn't support UTF-8 (I have added two FIXME notes in it's source, and it was at first glance). Use widgets.StyledText instead. Linux version: Still unstable. I haven't tested it yet.
Oct 07 2011
next sibling parent reply Jacob Carlborg <doob me.com> writes:
On 2011-10-08 08:49, Denis Shelomovskij wrote:
 07.10.2011 9:19, Jacob Carlborg пишет:
 On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053
 DMD2.054
 DMD2.055, Because of .length type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

widget,say Chinese characters?

It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket

About win32 version: widgets.Text doesn't support UTF-8 (I have added two FIXME notes in it's source, and it was at first glance). Use widgets.StyledText instead. Linux version: Still unstable. I haven't tested it yet.

Could you report a ticket please. Or can I pull from your repository? -- /Jacob Carlborg
Oct 08 2011
parent reply Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
08.10.2011 17:17, Jacob Carlborg пишет:
 On 2011-10-08 08:49, Denis Shelomovskij wrote:
 07.10.2011 9:19, Jacob Carlborg пишет:
 On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053
 DMD2.054
 DMD2.055, Because of .length type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

widget,say Chinese characters?

It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket

About win32 version: widgets.Text doesn't support UTF-8 (I have added two FIXME notes in it's source, and it was at first glance). Use widgets.StyledText instead. Linux version: Still unstable. I haven't tested it yet.

Could you report a ticket please. Or can I pull from your repository?

They are in my commit: http://hg.dsource.org/projects/dwt2/rev/536e43f63c81 in section +++ b/org.eclipse.swt.win32.win32.x86/src/org/eclipse/swt/widgets/Text.d And a few messages I had written to "doob" few months ago about that commit. Some text from it cab be put into DWT wiki for developers. ---------- denis_sh wrote at 3:47 p.m. on 9 July 2011 ... It looks working good on Windows except Text widget sill doesn't support UTF-8 and working a little on Linux: lots of segfaults when printing and text editing and other bugs. I have no idea how to contribute this project, because someone decided to work internally with UTF-8 instead of UTF-16 and it causes tons of bugs (on Windows and at least some on Linux) and it kills "easy future merges". Encoding bugs in DWT are alive for many long years and are looking hard to find and fix. Worst of all original SWT knows almost nothing about UTF-16 surrogate pairs ("almost", because nevertheless few fixes exists in the latest versions) AND likes to call func(string, start, end) where end is the last character index instead (no idea why they did it) an "index after the last" as is customary and then suppose that the "index after the last" is end+1. And SWT still has this bug. But it become critical in DWT because UTF-8 sequences as against UTF-16 surrogate pairs are very common. So I think DWT in it's current state doesn't worth all that hours of fixing and testing. It should be just a DIRECT port of SWT, without encoding conversion or it should has a big command of coders/testers to find and fix all SWT and DWT bugs. Or I missed something? ---------- ... ---------- denis_sh wrote at 10:26 p.m. on 9 July 2011 Last paragraph... If I've fixed almost all encoding bugs in Win32 version (except Text widget), than it is no problem. I really hope such is the case. But I'm afraid that lots of same bugs are in other modules too and it sounds very terrible. I think it is a good idea to fix SWT encoding bugs but we haven't enough people. Years of bugs are self explanatory. To tell the truth, I'm just very tired of fixing encoding problems. ---------- denis_sh wrote at 10:22 a.m. on 10 July 2011 A bit more about "easy future merges". Let's suppose SWT porting is done. And now he want to port JFace, e.g. Let's than suppose it is a call to swt.widgets.Text.getText (int start, int end) somewhare in JFace and the call is like text.getText (0, s.length - 1). How should we find that call? IMHO, the good approach is "it works if compiles". So we are to rename getText to DWTgetText e.g. and manually explore every compilation error. In conclusion, SWT porting in not done and such situation can be in SWT itself. ---------- ... ---------- denis_sh wrote at 1:04 p.m. on 10 July 2011 Yes, it is really hard to find a suggestion in my posts. Because I don't know it. More precisely I don't see any fast solution and don't want to work for a long one. DWT now partially works, so let it be. Until someone will find a good solution and time to make a reality.
Oct 10 2011
parent Jacob Carlborg <doob me.com> writes:
On 2011-10-10 11:02, Denis Shelomovskij wrote:
 They are in my commit:
 http://hg.dsource.org/projects/dwt2/rev/536e43f63c81
 in section
 +++ b/org.eclipse.swt.win32.win32.x86/src/org/eclipse/swt/widgets/Text.d

Aha, ok.
 And a few messages I had written to "doob" few months ago about that
 commit. Some text from it cab be put into DWT wiki for developers.

I'll have a look at that.
 ----------
 denis_sh wrote at 3:47 p.m. on 9 July 2011

 ...

 It looks working good on Windows except Text widget sill doesn't support
 UTF-8 and working a little on Linux: lots of segfaults when printing and
 text editing and other bugs.

 I have no idea how to contribute this project, because someone decided
 to work internally with UTF-8 instead of UTF-16 and it causes tons of
 bugs (on Windows and at least some on Linux) and it kills "easy future
 merges". Encoding bugs in DWT are alive for many long years and are
 looking hard to find and fix.

 Worst of all original SWT knows almost nothing about UTF-16 surrogate
 pairs ("almost", because nevertheless few fixes exists in the latest
 versions) AND likes to call func(string, start, end) where end is the
 last character index instead (no idea why they did it) an "index after
 the last" as is customary and then suppose that the "index after the
 last" is end+1. And SWT still has this bug.

 But it become critical in DWT because UTF-8 sequences as against UTF-16
 surrogate pairs are very common.

 So I think DWT in it's current state doesn't worth all that hours of
 fixing and testing. It should be just a DIRECT port of SWT, without
 encoding conversion or it should has a big command of coders/testers to
 find and fix all SWT and DWT bugs. Or I missed something?


 ----------
 ...


 ----------
 denis_sh wrote at 10:26 p.m. on 9 July 2011

 Last paragraph...

 If I've fixed almost all encoding bugs in Win32 version (except Text
 widget), than it is no problem. I really hope such is the case. But I'm
 afraid that lots of same bugs are in other modules too and it sounds
 very terrible. I think it is a good idea to fix SWT encoding bugs but we
 haven't enough people. Years of bugs are self explanatory.

 To tell the truth, I'm just very tired of fixing encoding problems.


 ----------
 denis_sh wrote at 10:22 a.m. on 10 July 2011

 A bit more about "easy future merges". Let's suppose SWT porting is
 done. And now he want to port JFace, e.g. Let's than suppose it is a
 call to swt.widgets.Text.getText (int start, int end) somewhare in JFace
 and the call is like text.getText (0, s.length - 1). How should we find
 that call? IMHO, the good approach is "it works if compiles". So we are
 to rename getText to DWTgetText e.g. and manually explore every
 compilation error.

 In conclusion, SWT porting in not done and such situation can be in SWT
 itself.


 ----------
 ...


 ----------
 denis_sh wrote at 1:04 p.m. on 10 July 2011

 Yes, it is really hard to find a suggestion in my posts. Because I don't
 know it.

 More precisely I don't see any fast solution and don't want to work for
 a long one.

 DWT now partially works, so let it be. Until someone will find a good
 solution and time to make a reality.

Oh, yeah, this mess again. I guess UTF-8 was chosen because it's the default string type for D. Using UTF-16 would probably be easier, at least for the developers porting the code. -- /Jacob Carlborg
Oct 10 2011
prev sibling parent reply Sam Hu <samhudotsamhu gmail.com> writes:
Denis Shelomovskij Wrote:

 07.10.2011 9:19, Jacob Carlborg пишет:
 On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053
 DMD2.054
 DMD2.055, Because of .length type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

widget,say Chinese characters?

It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket

About win32 version: widgets.Text doesn't support UTF-8 (I have added two FIXME notes in it's source, and it was at first glance). Use widgets.StyledText instead. Linux version: Still unstable. I haven't tested it yet.

Exeption message: dchar decode(in char[],ref size_t):Invalid UTF8 sequence [206,196,65,66,67] around index 0
Oct 08 2011
next sibling parent Jacob Carlborg <doob me.com> writes:
On 2011-10-09 04:47, Sam Hu wrote:
 Denis Shelomovskij Wrote:

 07.10.2011 9:19, Jacob Carlborg пишет:
 On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053
 DMD2.054
 DMD2.055, Because of .length type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

widget,say Chinese characters?

It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket

About win32 version: widgets.Text doesn't support UTF-8 (I have added two FIXME notes in it's source, and it was at first glance). Use widgets.StyledText instead. Linux version: Still unstable. I haven't tested it yet.

Exeption message: dchar decode(in char[],ref size_t):Invalid UTF8 sequence [206,196,65,66,67] around index 0

Could you please report a ticket so it's not forgotten? -- /Jacob Carlborg
Oct 09 2011
prev sibling parent Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
09.10.2011 5:47, Sam Hu :
 Denis Shelomovskij Wrote:

 07.10.2011 9:19, Jacob Carlborg пишет:
 On 2011-10-07 04:52, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-10-03 04:29, Sam Hu wrote:
 Jacob Carlborg Wrote:

 On 2011-09-29 09:55, raojm wrote:
 DWT2 cannot compile right on 64Bit Linux Or Windows with DMD2.053
 DMD2.054
 DMD2.055, Because of .length type is ulong on 64Bit system.

Only 32bit platforms are ported in DWT. It does not work on 64bit platforms. -- /Jacob Carlborg


There are no pre-compiled packages. Source code: http://hg.dsource.org/projects/dwt2 Project page: http://www.dsource.org/projects/dwt -- /Jacob Carlborg

widget,say Chinese characters?

It should work. I've tested UTF8 characters outside the ASCII table but not Chinese characters. If it doesn't work please file a bug at: http://www.dsource.org/projects/dwt/newticket

About win32 version: widgets.Text doesn't support UTF-8 (I have added two FIXME notes in it's source, and it was at first glance). Use widgets.StyledText instead. Linux version: Still unstable. I haven't tested it yet.

Exeption message: dchar decode(in char[],ref size_t):Invalid UTF8 sequence [206,196,65,66,67] around index 0

Post test-case, please. I hope I will fix StyledText as soon as I will be able to reproduce it.
Oct 10 2011
prev sibling parent Andrej Mitrovic <andrej.mitrovich gmail.com> writes:
Hey, so why are all those snippets named by numbers? There's a bunch
of cool snippets here: http://www.eclipse.org/swt/snippets/

but I can't tell whether they're already in the snippets folder in DWT
since they're just named with numbers. I've ported a few to D, the
porting process seems to be really simple (in fact it wouldn't be a
bad idea to have a script to do the conversion automatically, when it
can).

I've also tried to port a Browser snippet, but Browser seems to be a
module that's only in the linux packages in dwt.
Sep 05 2011
prev sibling parent reply "Mr. Anonymous" <mailnew4ster gmail.com> writes:
On 03.08.2011 23:02, Denis Shelomovskij wrote:
 About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
 time to pull changes to the main repo. Changes are in my (denis_sh)
 commits descriptions:
 https://bitbucket.org/denis_sh/patching-dwt2

 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
 worse): lots of segfaults when printing and text editing and other bugs.
 2. It looks working stable on Windows except Text widget sill doesn't
 support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

Where is the newest repo? I found this on bitbucket: https://bitbucket.org/kntroh/dwt2-with-d2/ with code commited today. Is it the "official" DWT2 place?
Dec 24 2011
next sibling parent kntroh <knt.roh gmail.com> writes:
 I found this on bitbucket:
 https://bitbucket.org/kntroh/dwt2-with-d2/
 with code commited today.
 Is it the "official" DWT2 place?

No, it is my private clone. I send a patch using this repository sometimes. Now I am waiting to fix this ticket. http://www.dsource.org/projects/dwt/ticket/30
Dec 25 2011
prev sibling parent Jacob Carlborg <doob me.com> writes:
On 2011-12-24 20:44, Mr. Anonymous wrote:
 On 03.08.2011 23:02, Denis Shelomovskij wrote:
 About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
 time to pull changes to the main repo. Changes are in my (denis_sh)
 commits descriptions:
 https://bitbucket.org/denis_sh/patching-dwt2

 Short changes description:
 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
 worse): lots of segfaults when printing and text editing and other bugs.
 2. It looks working stable on Windows except Text widget sill doesn't
 support UTF-8 (yes, StyledText and it's friend now support it).
 3. It now have compilable and right snippets.

Where is the newest repo? I found this on bitbucket: https://bitbucket.org/kntroh/dwt2-with-d2/ with code commited today. Is it the "official" DWT2 place?

The official repository currently is: http://hg.dsource.org/projects/dwt2 I've started to move the repository to github but the move is not finished yet. -- /Jacob Carlborg
Dec 25 2011