digitalmars.D.bugs - [Issue 9699] New: strip functions should allow setting custom match character
- d-bugmail puremagic.com (18/18) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (10/10) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (24/24) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (9/28) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (20/45) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (12/12) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (8/11) Mar 12 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (11/11) May 27 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (12/12) Sep 27 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
- d-bugmail puremagic.com (9/9) Sep 27 2013 http://d.puremagic.com/issues/show_bug.cgi?id=9699
http://d.puremagic.com/issues/show_bug.cgi?id=9699 Summary: strip functions should allow setting custom match character Product: D Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Phobos AssignedTo: andrej.mitrovich gmail.com ReportedBy: andrej.mitrovich gmail.com 05:40:16 PDT --- This applies to strip, stripLeft, and stripRight. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 Andrej Mitrovic <andrej.mitrovich gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull 05:47:31 PDT --- https://github.com/D-Programming-Language/phobos/pull/1201 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 bearophile_hugs eml.cc changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bearophile_hugs eml.cc Regarding this code I have two comments: C[] stripRight(C)(C[] str) if(isSomeChar!C) { foreach_reverse(i, dchar c; str) { if(!std.uni.isWhite(c)) return str[0 .. i + codeLength!C(c)]; } return str[0 .. 0]; } 1) Isn't it enough a "return null;" at the end? 2) When I see such string functions I often think about stripping leading values from a generic 1D array: [0,0,0,0,10,7,1234,0] -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 06:28:25 PDT ---Regarding this code I have two comments: C[] stripRight(C)(C[] str) if(isSomeChar!C) { foreach_reverse(i, dchar c; str) { if(!std.uni.isWhite(c)) return str[0 .. i + codeLength!C(c)]; } return str[0 .. 0]; } 1) Isn't it enough a "return null;" at the end?It's enough but it's different. At the call site !is null checks will depend on what is returned here.2) When I see such string functions I often think about stripping leading values from a generic 1D array: [0,0,0,0,10,7,1234,0]I don't know what is being asked here. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 monarchdodra gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |monarchdodra gmail.comFurther more, "strip" returns a "sub slice" of the original slice. If you return null, then "sameHead(str, stripRight(str))" will not be guaranteed. Very very minor points, but I see no reason to do things wrong when you can do them right. besides, str[0 .. 0] doesn't trigger bounds checking, so there is no overhead compared to null anyways.Regarding this code I have two comments: C[] stripRight(C)(C[] str) if(isSomeChar!C) { foreach_reverse(i, dchar c; str) { if(!std.uni.isWhite(c)) return str[0 .. i + codeLength!C(c)]; } return str[0 .. 0]; } 1) Isn't it enough a "return null;" at the end?It's enough but it's different. At the call site !is null checks will depend on what is returned here.He's basically saying there's no real reason for strip to be limited to just strings, and could operate on arrays or ranges. I'd kind of agree, but given our current clusterfuck with splitter, I think we need to think long and hard before adding anything. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------2) When I see such string functions I often think about stripping leading values from a generic 1D array: [0,0,0,0,10,7,1234,0]I don't know what is being asked here.
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 Andrej Mitrovic <andrej.mitrovich gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|pull | AssignedTo|andrej.mitrovich gmail.com |nobody puremagic.com 14:04:55 PDT --- I'll work on this some other time unless someone else implements it before me. Andrei now wants this to be completely generic and put into std.algorithm. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699I'll work on this some other time unless someone else implements it before me. Andrei now wants this to be completely generic and put into std.algorithm.In my code 99% of times I want to strip strings. Only once in a lot of time I'd like to strip a generic 1D array. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Mar 12 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 Andrej Mitrovic <andrej.mitrovich gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull AssignedTo|nobody puremagic.com |andrej.mitrovich gmail.com 04:33:56 PDT --- https://github.com/D-Programming-Language/phobos/pull/1311 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 27 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 Commits pushed to master at https://github.com/D-Programming-Language/phobos https://github.com/D-Programming-Language/phobos/commit/904682ac78e503fef8c57475634a8026bb6d2f20 Fixes Issue 9699 - Implement generic strip/stripLeft/stripRight functions which accept an element or a predicate. https://github.com/D-Programming-Language/phobos/commit/8503ed1e2329cd1b14a0e470dbdb12206a0e49a8 Issue 9699 - Implement generic strip/stripLeft/stripRight functions -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Sep 27 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9699 Andrej Mitrovic <andrej.mitrovich gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Sep 27 2013