www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 9369] New: DDoc hardcodes '&' -> '&' in code

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369

           Summary: DDoc hardcodes '&' -> '&' in code
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: andrei erdani.com


--- Comment #0 from Andrei Alexandrescu <andrei erdani.com> 2013-01-22 11:38:10
PST ---
Code samples introduced with '----' have all ampersands replaced with '&amp;'.
This HTMLism makes it impossible to translate to other document formats.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 22 2013
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla digitalmars.com


--- Comment #1 from Walter Bright <bugzilla digitalmars.com> 2013-01-22
14:39:14 PST ---
https://github.com/D-Programming-Language/dmd/pull/1535

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 22 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #2 from github-bugzilla puremagic.com 2013-01-22 15:36:22 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/87ee81ad633dd65274482027b5dcd2d48eefa85f
fix Issue 9369 - DDoc hardcodes '&' -> '&amp;' in code

https://github.com/D-Programming-Language/dmd/commit/2471fe912b0707e30be3c7b58d5a0f70a0f6a796
Merge pull request #1535 from WalterBright/fix9369

fix Issue 9369 - DDoc hardcodes '&' -> '&amp;' in code

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 22 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 22 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369


Andrei Alexandrescu <andrei erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


--- Comment #3 from Andrei Alexandrescu <andrei erdani.com> 2013-01-23 09:41:29
PST ---
With the new release, attempting to compile the following file crashes dmd:

=======dlangspec-tex.d begins here
Ddoc

---
a=1;
---
=======dlangspec-tex.d ends here

The command invoked is:

dmd dlangspec-tex.d

I have updated the compiler, druntime, and phobos, made a clean 64-bit build.
Can you reproduce this?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #4 from Walter Bright <bugzilla digitalmars.com> 2013-01-23
12:28:46 PST ---
Yes, I can reproduce it.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #5 from Walter Bright <bugzilla digitalmars.com> 2013-01-23
13:20:08 PST ---
https://github.com/D-Programming-Language/dmd/pull/1541

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #6 from github-bugzilla puremagic.com 2013-01-23 17:19:07 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/77fbee1ef470d8916c1cc34fd0a91869f9292427
fix Issue 9369 - DDoc hardcodes '&' -> '&amp;' in code

https://github.com/D-Programming-Language/dmd/commit/9f780b01c551ff86b6cb9b9acd152dce158a7419
Merge pull request #1541 from WalterBright/fix9369again

fix Issue 9369 - DDoc hardcodes '&' -> '&amp;' in code

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369


Andrei Alexandrescu <andrei erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


--- Comment #7 from Andrei Alexandrescu <andrei erdani.com> 2013-01-23 22:15:41
PST ---
Sorry, still no cigar.

There are a few side effects of this change.

* There are a lot more $(BR) introduced in the output. I think that's not bad
actually, but it is a change in behavior.
* The words "true", "false", and "null" now appear in DDOC_KEYWORD style
everywhere. I had to define DDOC_KEYWORD=$0 to get rid of that. Let's say
that's not bad either.
* The main problem (and the reason I'm reopening this) is that now all code
words that start with an underscore have it chopped off. For example $(D
__FILE__) becomes _FILE__. I suppose that's because of the logic to avoid
highlighting. That logic needs to somehow be removed in the general case.

Everything else seems to work fine. Thanks!

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #8 from Walter Bright <bugzilla digitalmars.com> 2013-01-23
22:26:18 PST ---
(In reply to comment #7)
 There are a few side effects of this change.

In ddoc files or d source code files? -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Jan 23 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #9 from Walter Bright <bugzilla digitalmars.com> 2013-01-24
15:31:56 PST ---
https://github.com/D-Programming-Language/dmd/pull/1547

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 24 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369



--- Comment #10 from github-bugzilla puremagic.com 2013-01-24 16:02:38 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/c6e9191923faa52244feaf67772617f78ae07da0
fix Issue 9369 - DDoc hardcodes '&' -> '&amp;' in code

https://github.com/D-Programming-Language/dmd/commit/e7e0d1729994baee870d7b933292a8c22d8f3aa9
Merge pull request #1547 from WalterBright/b30

fix Issue 9369 - DDoc hardcodes '&' -> '&amp;' in code

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 24 2013
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=9369


Andrei Alexandrescu <andrei erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 24 2013