digitalmars.D.bugs - [Issue 5849] New: std.random.dice is better as a range
- d-bugmail puremagic.com (65/65) Apr 16 2011 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (6/6) Apr 24 2011 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (11/11) Dec 29 2011 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (10/10) Dec 29 2011 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (23/24) Jan 04 2012 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (7/7) May 28 2012 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (8/8) Jul 01 2012 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (31/31) Aug 31 2013 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (14/23) Aug 31 2013 http://d.puremagic.com/issues/show_bug.cgi?id=5849
- d-bugmail puremagic.com (7/7) Aug 31 2013 http://d.puremagic.com/issues/show_bug.cgi?id=5849
http://d.puremagic.com/issues/show_bug.cgi?id=5849
Summary: std.random.dice is better as a range
Product: D
Version: D2
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Phobos
AssignedTo: nobody puremagic.com
ReportedBy: bearophile_hugs eml.cc
When I have to use std.random.dice the frequencies don't change often, but I
usually have to compute many random values efficiently. Calling dice() many
times is not efficient, because it performs some preprocessing of the given
frequencies.
So I suggest to replace the function dice(xxx) with a range that generates the
results.
So the current usage of:
dice(70, 20, 10)
gets replaced by:
dice(70, 20, 10).front
And you are able to write:
take(dice(70, 20, 10), 5)
The good thing of this generator is its performance compared to the function.
See the performance difference between the two following implementations (5.3
seconds for the first version and 0.7 seconds for the second one).
------------------------
import std.stdio, std.random, std.string;
void main() {
enum int N = 10_000_000;
enum pr = [1/5., 1/6., 1/7., 1/8., 1/9., 1/10., 1/11., 1759/27720.];
double[pr.length] counts = 0.0;
foreach (i; 0 .. N)
counts[dice(pr)]++;
foreach (i, p; pr)
writefln("%.8f %.8f", p, counts[i] / N);
}
------------------------
import std.stdio, std.random, std.string;
void main() {
enum int N = 10_000_000;
enum pr = [1/5., 1/6., 1/7., 1/8., 1/9., 1/10., 1/11., 1759/27720.];
double[pr.length] cumulatives = pr[];
foreach (i, ref c; cumulatives[1 .. $-1])
c += cumulatives[i];
cumulatives[$-1] = 1.0;
double[pr.length] counts = 0.0;
auto rnd = Xorshift(unpredictableSeed());
foreach (i; 0 .. N) {
double rnum = rnd.front() / cast(double)typeof(rnd.front()).max;
rnd.popFront();
int j;
for ( ; rnum > cumulatives[j]; j++) {}
counts[j]++;
}
foreach (i, p; pr)
writefln("%.8f %.8f", p, counts[i] / N);
}
-------------------------
See also some other improvements I have suggested for std.random.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Apr 16 2011
d-bugmail puremagic.com http://d.puremagic.com/issues/show_bug.cgi?id=5849 See also issue 5883 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Apr 24 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5849 Created an attachment (id=1060) First draft of a fast dice range D code adapted from Java code: http://www.keithschwarz.com/interesting/code/?dir=alias-method http://www.keithschwarz.com/darts-dice-coins/ http://www.reddit.com/r/programming/comments/nu78s/darts_dice_and_coins_a_beautiful_algorithm_for/ -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Dec 29 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5849
Andrei Alexandrescu <andrei metalanguage.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrei metalanguage.com
16:00:18 PST ---
You may want to package contributions as pull requests. Thanks!
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 29 2011
http://d.puremagic.com/issues/show_bug.cgi?id=5849
bearophile_hugs eml.cc changed:
What |Removed |Added
----------------------------------------------------------------------------
is obsolete| |
Created an attachment (id=1066)
Version 0.5 of the fast dice
You may want to package contributions as pull requests. Thanks!
Thank you. I think the current code is not yet fit for a pull request, there
are some things to be done/solved first:
- Create statistical unittests.
- Is popLast() overkill/not useful enough?
- Is the Range correct now?
- Is uint[] enough for mAlias?
- ddoc comments are missing still.
- Currently the Dice constructor lacks a pre-condition: I think the input
probabilities must sum to 1.0. But is this necessary? An alternative
design is to accept any array of numbers (integers too), and normalize
their sum to 1.0 inside the Dice constructor itself.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 04 2012
http://d.puremagic.com/issues/show_bug.cgi?id=5849 See also: https://github.com/D-Programming-Language/phobos/pull/553 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
May 28 2012
http://d.puremagic.com/issues/show_bug.cgi?id=5849 Probably partially done here: https://github.com/D-Programming-Language/phobos/pull/553 https://github.com/D-Programming-Language/phobos/commit/a47707a19796c41a9cb77ae9ae09605afd56fa6f -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Jul 01 2012
http://d.puremagic.com/issues/show_bug.cgi?id=5849
If we don't want to break the API of dice() making it a range, a simple
solution is to call the dice range "diceRange" and keep both (but perhaps dice
becomes a small function that returns diceRange.front).
Another interesting suggestion: in my code I've seen that most times I want to
use a dice/diceRange I have to map its result on the items of an array:
import std.stdio, std.random;
void main() {
immutable probabilities = [0.2, 0.6, 0.1, 0.1];
immutable values = "ACGT";
foreach (_; 0 .. 10)
values[probabilities.dice].write;
}
That outputs something similar to:
CGCCAAACCC
So an improvement for diceRange() is to accept as first argument the range of
probabilities, and as second optional argument a range of items. If the second
argument is not given, then it generates integers as dice(). If the second
argument is given, then it yields the items, according to their probabilities.
So that program becomes:
import std.stdio, std.random, std.range;
void main() {
immutable probabilities = [0.2, 0.6, 0.1, 0.1];
immutable values = "ACGT";
probabilities.diceRange(values).take(10).writeln;
}
This is quite handy.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 31 2013
http://d.puremagic.com/issues/show_bug.cgi?id=5849
import std.stdio, std.random, std.range;
void main() {
immutable probabilities = [0.2, 0.6, 0.1, 0.1];
immutable values = "ACGT";
probabilities.diceRange(values).take(10).writeln;
}
This is quite handy.
If the second optional argument is not supported, then the code becomes:
import std.stdio, std.random, std.range;
void main() {
immutable probabilities = [0.2, 0.6, 0.1, 0.1];
immutable values = "ACGT";
probabilities.diceRange.map!(i => values[i]).take(10).writeln;
}
But I am not sure it's strictly equivalent.
--
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 31 2013
http://d.puremagic.com/issues/show_bug.cgi?id=5849 Also, why is the random generator engine the first optional argument of dice(), while it's the last for uniform()? -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Aug 31 2013