www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 4973] New: map file with spaces in file name passed without quotes to linker

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4973

           Summary: map file with spaces in file name passed without
                    quotes to linker
           Product: D
           Version: D1 & D2
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Keywords: link-failure, patch
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: r.sagitario gmx.de


--- Comment #0 from Rainer Schuetze <r.sagitario gmx.de> 2010-10-02 00:15:31
PDT ---
Specifying a map file to dmd that contains spaces like this

  dmd test.d -map "a b.map" -v

produces

binary    c:\l\dmd-2.048\windows\bin\dmd.exe
version   v2.048
[...]
c:\l\dmd-2.048\windows\bin\link.exe test,,a b.map,user32+kernel32/m/noi;
OPTLINK (R) for Win32  Release 8.00.2
Copyright (C) Digital Mars 1989-2009  All rights reserved.
http://www.digitalmars.com/ctg/optlink.html
user32.def(0) : Error 2: File Not Found user32.def
--- errorlevel 1

showing that the map file name is not quoted.

Here's the patch:

Index: link.c
===================================================================
--- link.c    (revision 701)
+++ link.c    (working copy)
   -116,7 +116,7   

     cmdbuf.writeByte(',');
     if (global.params.mapfile)
-        cmdbuf.writestring(global.params.mapfile);
+        writeFilename(&cmdbuf, global.params.mapfile);
     else if (global.params.run)
         cmdbuf.writestring("nul");
     cmdbuf.writeByte(',');

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 02 2010
parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4973


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |bugzilla digitalmars.com
         Resolution|                            |FIXED


--- Comment #1 from Walter Bright <bugzilla digitalmars.com> 2011-02-06
23:39:55 PST ---
https://github.com/D-Programming-Language/dmd/commit/ec462eeacd0c6f88f4baa9f9e6c7add41a842e6a

https://github.com/D-Programming-Language/dmd/commit/b93d4c15fa59da5633d73274985e9fc80db9438d

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 06 2011