www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 4613] New: temporary generated inside foreach is not correctly destructed

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4613

           Summary: temporary generated inside foreach is not correctly
                    destructed
           Product: D
           Version: D2
          Platform: Other
        OS/Version: Mac OS X
            Status: NEW
          Severity: major
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: andy aligature.com


--- Comment #0 from andy aligature.com 2010-08-10 08:54:33 PDT ---
Using dmd v2.047 it seems like there is a bug when generating a temporary
inside a foreach statement.  Here's an example.

<code>

#!/usr/bin/env rdmd

import std.stdio;
import std.conv;

struct MyFile
{
   private struct Impl
   {
      uint refs = 0;
      string name;

      this(uint r, string n)
      {
         refs = r;
         name = n;
      }
   }
   private Impl* p;

   this(string s)
   {
      writeln("MyFile ctor ", s);
      p = new Impl(1, s);
   }

   this(this)
   {
      writeln("Adding ref ", p.name);
      ++p.refs;
   }

   ~this()
   {
      writeln("MyFile dtor ", p.name);
      if(p.refs == 1) close;
      else{ writeln("Removing ref ", p.name); --p.refs;}
   }

   void close()
   {
      writeln("close ", p.name);
      scope(exit) p = null;
   }

   int opApply(int delegate(ref char) dg)
   {
      foreach(char c; p.name)
      {
         dg(c);
      }
      return 0;
   }
}

void doOne()
{
   writeln("begin one");
   auto f = MyFile("one");
   foreach(c; f)
   {
      writeln(c);
   }
   writeln("end one");
}

void doTwo()
{
   writeln("begin two");
   foreach(c; MyFile("two"))
   {
      writeln(c);
   }
   writeln("end two");
}

void main()
{
   writeln("before one");
   doOne();
   writeln("after one");
   writeln("before two");
   doTwo();
   writeln("after two");
}

</code>


The first case is handled correctly.  When the scope of doOne() ends, the f
instance is correctly destroyed.  However, in doTwo(), the temporary MyFile
created in the foreach statement is not destroyed.  In this case, "MyFile dtor
two" and "close two" should be printed before "after two".  I hit this bug
specifically when using something like  foreach(ubyte[] buf; chunks(file,
4096)).  This keeps file handles open past their lifetime and is causing a file
handle leak in my app.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 10 2010
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4613



--- Comment #1 from andy aligature.com 2010-08-10 08:56:01 PDT ---
Here is the output from a test run of the example.

<output>

andy curie:~/Projects/d> ./test.d
before one
begin one
MyFile ctor one
o
n
e
end one
MyFile dtor one
close one
after one
before two
begin two
MyFile ctor two
t
w
o
end two
after two

</output>

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4613


Don <clugdbug yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
                 CC|                            |clugdbug yahoo.com.au
           Severity|major                       |critical


--- Comment #2 from Don <clugdbug yahoo.com.au> 2010-09-20 08:41:23 PDT ---
Probably a dup of bug 3516 -- the worst open bug in DMD.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 20 2010
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4613


Don <clugdbug yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE


--- Comment #3 from Don <clugdbug yahoo.com.au> 2010-09-22 04:05:41 PDT ---
*** This issue has been marked as a duplicate of issue 3516 ***

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Sep 22 2010