www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 4398] New: dmd always uses Windows name mangling for _d_throw

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398

           Summary: dmd always uses Windows name mangling for _d_throw
           Product: D
           Version: D1 & D2
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: johannespfau gmail.com



PDT ---
When calling _d_throw dmd always uses the name _d_throw 4 regardless of the
operating system. Dynamic ELF libraries support versioning symbols using the
syntax name version. Therefore when ld encounters _d_throw 4 it reads "symbol
_d_throw, version 4" and complains that there is no version 4. As long as this
isn't fixed Dynamic D libraries can't be created on operating systems using ELF
executables.

See also:
http://www.digitalmars.com/pnews/read.php?server=news.digitalmars.com&group=digitalmars.D&artnum=112648
and the links referred in the newspost.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 27 2010
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---
Created an attachment (id=678)
Patch for dmd2

Patch for dmd2.
This patch also fixes the _seh_longjmp_unwind 4 and _cpp_longjmp_unwind 4
symbols. This might not be necessary, it seems those symbols are used on
windows only.

This also requires a patch to druntime, and both must be applied or there will
be link errors on linux.

BTW: If I understand windows name mangling correctly,  4 means the arguments
have size 4 bytes. As the argument is a pointer hardcoding it to 4 will not
work on 64bit.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 27 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---
Created an attachment (id=679)
Patch for druntime

This is the patch required for druntime.

In /src/rt/deh2.d "void _d_throw(Object *h)" must be extern(Windows) for
windows and extern(C) for all other platforms.

In /src/rt/deh.c "void __stdcall _d_throw(Object *h)" must have __stdcall for
windows and "void _d_throw(Object *h)" for all other platforms.

The other 2 symbols modified in the dmd patch are not used in druntime.

This patch places the whole functions in version blocks. Therefore a lot of
code is duplicated. I guess this could be done in a better way, but I could get
it to work with e.g. alias.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 27 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---
I wanted to say "but I could _not_ get
it to work with e.g. alias".

A different solution to this problem is to use extern(C) everywhere, even for
windows. This also solves the 64bit problem. However, I'm not sure why
__stdcall was used on windows, maybe it is needed (performance related?).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 27 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---
First of all, thanks for tackling this!

I wonder if there is any way to avoid code duplication in druntime, as (unless
I'm missing something) the _d_throw() body seems to be the same for Windows and
Posix, only the function signature changes.

Isn't extern (System) -which, btw, seems to be missing in the docs- exactly for
this case?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 27 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Eldar Insafutdinov <e.insafutdinov gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.insafutdinov gmail.com



03:11:27 PDT ---
To avoid code duplication in case extern(System) won't help you here you can
use string mixins.

P.S. Is it the only issue that prevents dmd from being able to build shared
libraries on linux or there are more?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Jacob Carlborg <doob me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doob me.com



The runtime needs to be modified of course, then there is always the chance of
new bugs showing up.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---


 To avoid code duplication in case extern(System) won't help you here


Why? Doesn't extern(System) means extern(Windows) if version is Windows and
extern (C) if version is Posix?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




06:46:39 PDT ---




 To avoid code duplication in case extern(System) won't help you here


 
 Why? Doesn't extern(System) means extern(Windows) if version is Windows and
 extern (C) if version is Posix?


Yes that's entirely correct. I meant that in case you have some other types of
linkage or other variations in function signature you can use string mixins.
Sorry for confusion.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---






 To avoid code duplication in case extern(System) won't help you here


 
 Why? Doesn't extern(System) means extern(Windows) if version is Windows and
 extern (C) if version is Posix?


 
 Yes that's entirely correct. I meant that in case you have some other types of
 linkage or other variations in function signature you can use string mixins.
 Sorry for confusion.


Woops, my eyes completely ignored the "in case". My mistake =)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Johannes Pfau <johannespfau gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------

           obsolete|                            |



PDT ---
Created an attachment (id=683)
Updated patch for druntime

Added a new patch for druntime using extern(System). If extern(System) is
extern(Windows) on windows and extern(C) on posix, this will work fine, I just
did not know about extern(System).

I also removed the version blocks in src/rt/deh.c (first it's a c file, so
version blocks don't belong there anyway, second the whole file is in an "#if
_WIN32" block)
(a stupid mistake, deh.c is not compiled on posix, so I didn't see the error)

(related note: deh2.d is not used on windows, so extern(C) would work as well,
just the current extern(Windows) can't work)

 Eldar Insafutdinov thanks for the string mixin advice

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Johannes Pfau <johannespfau gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------

           obsolete|                            |



PDT ---
Created an attachment (id=684)
Updated patch for dmd2

Somehow switched LONGJMP_MANGLE_NAME and CPP_LONGJMP_MANGLE_NAME in the first
patch.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---


 Created an attachment (id=683) [details]
 Updated patch for druntime
 
 Added a new patch for druntime using extern(System). If extern(System) is
 extern(Windows) on windows and extern(C) on posix, this will work fine, I just
 did not know about extern(System).


I filled a bug (bug 4399) because as far as I can see, it's undocumented (I
knew it existed because it's in the changelog and I remember some discussion
about it in the group).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Johannes Pfau <johannespfau gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------

           obsolete|                            |



PDT ---
Created an attachment (id=685)
Patch for druntime, third edition

I was wrong, there is a linux _d_throw(Object *h) in deh.c, but it seems
deprecated by deh2.d. Just in case this new patch also fixes the _d_throw in
deh.c.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 28 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


nfxjfg gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nfxjfg gmail.com



Most retarded patch ever and supports my theory that Walter is just trolling
everyone, instead of intending to produce something useful.

WHY.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398






 patch


I mean bug.
Uf dmd had a healthy development model, this should have been fixed 5 minutes
after the bug was reported.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---


 To avoid code duplication in case extern(System) won't help you here you can
 use string mixins.
 
 P.S. Is it the only issue that prevents dmd from being able to build shared
 libraries on linux or there are more?


I just tried the patches on dmd.1.064
It crashes upon new exception.












--Marenz

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




I don't think that the attached patches are correct. As far as I can see
looking at the makefiles, deh.c is used on windows and deh2.d is used on posix.
So _d_throw in deh2.d would be extern (C) or extern (Windows) (doesn't really
matter) then _d_throw in deh.c would still be __stdcall.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398






 I don't think that the attached patches are correct. As far as I can see
 looking at the makefiles, deh.c is used on windows and deh2.d is used on posix.
 So _d_throw in deh2.d would be extern (C) or extern (Windows) (doesn't really
 matter) then _d_throw in deh.c would still be __stdcall.


Sorry, extern (C) or extern (System)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---




 I don't think that the attached patches are correct. As far as I can see
 looking at the makefiles, deh.c is used on windows and deh2.d is used on posix.
 So _d_throw in deh2.d would be extern (C) or extern (Windows) (doesn't really
 matter) then _d_throw in deh.c would still be __stdcall.


 
 Sorry, extern (C) or extern (System)


Sorry, I should have mentioned: I tested on linux and I used tango (which has 
the same files). So the deh.c should not have been used at all, right?

--Marenz

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398










 I don't think that the attached patches are correct. As far as I can see
 looking at the makefiles, deh.c is used on windows and deh2.d is used on posix.
 So _d_throw in deh2.d would be extern (C) or extern (Windows) (doesn't really
 matter) then _d_throw in deh.c would still be __stdcall.


 
 Sorry, extern (C) or extern (System)


 
 Sorry, I should have mentioned: I tested on linux and I used tango (which has 
 the same files). So the deh.c should not have been used at all, right?
 
 --Marenz


Correct, deh.c should not have been used at all. But tango should not build
that file when building on linux.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Johannes Pfau <johannespfau gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------

           obsolete|                            |



PDT ---
Created an attachment (id=780)
Yet another druntime patch

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




PDT ---
True, deh.c should stay as it is. My understanding of C and druntime wasn't
that great at the time I wrote the patch. I'll attach an updated patch, but
Walter will likely have to look into this again anyway when he starts to
implement support for shared libraries on Linux. This patch alone won't help
much there though, it's just the first step for shared library support, there
are way bigger issues.

Tango and phobos1 need to be patched as well. I haven't looked into tango, but
if the code is the same as the druntime code the deh2.d patch should work. I
tested the patched compiler and druntime on Linux back then and I'm sure it
worked.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla digitalmars.com



21:37:52 PDT ---
deh.c is Windows only. It is in C because it interacts with all the complex
Windows header definitions for Windows SEH that have not been ported to D. D's
eh mechanism on Windows is layered on top of Windows SEH.

For other platforms, deh2.d is used instead, as D uses its own invented
exception handling mechanism. (It is not compatible with the C++ eh ELF
mechanism.)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 24 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




21:46:02 PDT ---
No need to mess with LONGJMP_MANGLE_NAME and CPP_LONGJMP_MANGLE_NAME as they
are for the C++ compiler. They are never referenced by dmd, and do not appear
in Phobos.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 24 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398




22:19:49 PDT ---
Compiler: http://www.dsource.org/projects/dmd/changeset/730
Phobos1: http://www.dsource.org/projects/phobos/changeset/2114
Druntime: http://www.dsource.org/projects/druntime/changeset/407

Note that I left the old _d_throw 8 in Phobos1 for binary compatibility with
libraries that link with Phobos. I suppose Tango will have to do the same
(provide the new entry point, as dmd1 now calls the new entry point).

Eventually, that entry point will be removed.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 24 2010
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4398


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 24 2010