www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 4332] New: C files in druntime should be converted to D

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332

           Summary: C files in druntime should be converted to D
           Product: D
           Version: D2
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: druntime
        AssignedTo: sean invisibleduck.org
        ReportedBy: clugdbug yahoo.com.au


--- Comment #0 from Don <clugdbug yahoo.com.au> 2010-06-16 13:12:23 PDT ---
complex.c, critical.c, deh.c, monitor.c, and memory_osx.c should all be
converted to D eventually. And D is a much better language for doing systems
programming anyway <g>.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 16 2010
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


nfxjfg gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nfxjfg gmail.com


--- Comment #1 from nfxjfg gmail.com 2010-06-17 02:53:30 PDT ---
Same for minit.asm and tls.S. If the inline assembler can't do it, it obviously
has to be extended to support the missing features (such defining global
symbols and sections).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jun 17 2010
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #2 from wfunction hotmail.com 2011-02-01 13:22:31 PST ---
Created an attachment (id=893)
D implementation of critical.c

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 01 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #3 from wfunction hotmail.com 2011-02-01 13:23:06 PST ---
Created an attachment (id=894)
D implementation of monitor.c

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 01 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #4 from wfunction hotmail.com 2011-02-01 13:24:52 PST ---
Created an attachment (id=895)
Changed monitor.c and critical.c into D

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 01 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #5 from wfunction hotmail.com 2011-02-01 13:25:27 PST ---
Created an attachment (id=896)
Changed monitor.c and critical.c into D

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 01 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


wfunction hotmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #893 is|0                           |1
           obsolete|                            |


--- Comment #6 from wfunction hotmail.com 2011-02-01 17:07:42 PST ---
Created an attachment (id=897)
D implementation of critical.d

I tried to leave the POSIX code in this time, even though I haven't tested it.
Hopefully this version is better, but apparently _d_criticalInit() needs to be
modified as well.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 01 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


wfunction hotmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #894 is|0                           |1
           obsolete|                            |


--- Comment #7 from wfunction hotmail.com 2011-02-01 17:08:36 PST ---
Created an attachment (id=898)
D implementation of monitor.d

I tried to leave the POSIX code in this time, even though I haven't tested it.
Hopefully this version is better, but apparently _d_criticalInit() needs to be
modified as well.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 01 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


Iain Buclaw <ibuclaw ubuntu.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw ubuntu.com


--- Comment #8 from Iain Buclaw <ibuclaw ubuntu.com> 2011-02-03 16:44:55 PST ---
Have taken the liberty of fixing Posix code, and pushed here:

https://github.com/ibuclaw/druntime/commit/4a2b70aea1df0cc4550b151b82f19655b5903279

Thanks!

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 03 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


Brad Roberts <braddr puremagic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |braddr puremagic.com


--- Comment #9 from Brad Roberts <braddr puremagic.com> 2011-02-06 23:38:00 PST
---
Something is wrong with the win32 conversion of monitor.c to monitor_.d.  I
merged Iain's version of the changes earlier today but it broke the win32 build
and tests.  So, I reverted just win32 back to using the C version.  If one of
you cooks up fixes, I'll be happy to re-test and merge them.

Thanks,
Brad

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 06 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #10 from Brad Roberts <braddr puremagic.com> 2011-02-07 01:15:44
PST ---
Further testing (dmd's test34) showed that the critical .c to .d change needed
to be reverted as well.  Win32 is back to using the .c version for both files
now.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 07 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #11 from Iain Buclaw <ibuclaw ubuntu.com> 2011-02-07 16:51:50 PST
---
Strange...

Are there any reasonable debuggers for Windows? I must admit I'm rather
terrible on the platform, but I could have a bash at seeing what's up, and why
it doesn't work (when Linux is just fine and dandy).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 07 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #12 from Iain Buclaw <ibuclaw ubuntu.com> 2011-02-15 10:21:44 PST
---
(In reply to comment #11)
 Strange...
 
 Are there any reasonable debuggers for Windows? I must admit I'm rather
 terrible on the platform, but I could have a bash at seeing what's up, and why
 it doesn't work (when Linux is just fine and dandy).
After a week of learning and painful struggling, I give up on Windows. Anyone else with better know-how willing to fix this? Regards -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 15 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


Trass3r <mrmocool gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrmocool gmx.de


--- Comment #13 from Trass3r <mrmocool gmx.de> 2011-02-18 05:17:32 PST ---
I think cv2pdb + Visual Studio is the only nice and working way to debug D on
Windows.
Which test was broken by monitor_.d?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 18 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #14 from Iain Buclaw <ibuclaw ubuntu.com> 2011-02-18 08:05:04 PST
---
Compile in both critical_ and monitor_ and *any* application built won't reach
main.

It crashes in _d_monitorenter in object_.d

    _d_monitor_create(h);
    m = getMonitor(h);     <-- Here as far as I could tell.


Good luck! :)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 18 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #15 from Iain Buclaw <ibuclaw ubuntu.com> 2011-02-25 13:36:21 PST
---
I'm just gonna throw it out there that upon compiling GDC2 on MinGW, the D
implementations of monitor and critical do not cause any problems on the
platform.

Regards

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 25 2011
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


Alex Rønne Petersen <alex lycus.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alex lycus.org
         Resolution|                            |FIXED


--- Comment #16 from Alex Rønne Petersen <alex lycus.org> 2012-10-10 03:43:03
CEST ---
This is now done.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 09 2012
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


Dmitry Olshansky <dmitry.olsh gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |dmitry.olsh gmail.com
         Resolution|FIXED                       |


--- Comment #17 from Dmitry Olshansky <dmitry.olsh gmail.com> 2012-10-10
00:37:00 PDT ---
While I know little of druntime internals I don't think this was delt with.
Why are critical.c and monitor.c still here in the repository then? Also Win32
section of monitor_.d is currently commented out.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2012
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #18 from Alex Rønne Petersen <alex lycus.org> 2012-10-10 16:25:14
CEST ---
(In reply to comment #17)
 While I know little of druntime internals I don't think this was delt with.
 Why are critical.c and monitor.c still here in the repository then? Also Win32
 section of monitor_.d is currently commented out.
I don't know where you are seeing these files. They are not there in my clone. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Oct 10 2012
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332


Alex Rønne Petersen <alex lycus.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


--- Comment #19 from Alex Rønne Petersen <alex lycus.org> 2012-10-10 16:26:50
CEST ---
See: https://github.com/D-Programming-Language/druntime/tree/master/src/rt

Closing again.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2012
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #20 from Dmitry Olshansky <dmitry.olsh gmail.com> 2012-10-10
11:53:27 PDT ---
(In reply to comment #19)
 See: https://github.com/D-Programming-Language/druntime/tree/master/src/rt
 
 Closing again.
Okay. Sorry for the confusion. Must have pulled stuff from my outdated clone. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Oct 10 2012
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=4332



--- Comment #21 from Alex Rønne Petersen <alex lycus.org> 2012-10-10 20:54:00
CEST ---
No prob!

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Oct 10 2012