www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 12178] New: ddoc arbitrarily injects tabs instead of spaces in the output

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178

           Summary: ddoc arbitrarily injects tabs instead of spaces in the
                    output
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: ddoc
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: andrej.mitrovich gmail.com


--- Comment #0 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2014-02-15
03:49:32 PST ---
Created an attachment (id=1324)
image

Note the space before the first "opt", and before and after the second "opt",
it's a tab instead of a space. It makes the docs look long and ugly.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 15 2014
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Kenji Hara <k.hara.pg gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID


--- Comment #1 from Kenji Hara <k.hara.pg gmail.com> 2014-02-16 01:14:50 PST ---
(In reply to comment #0)
 Created an attachment (id=1324) [details]
 image
 
 Note the space before the first "opt", and before and after the second "opt",
 it's a tab instead of a space. It makes the docs look long and ugly.

That's word wrapping of your browser view. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ddoc                        |
             Status|RESOLVED                    |REOPENED
          Component|DMD                         |websites
         Resolution|INVALID                     |


--- Comment #2 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2014-02-16
02:40:16 PST ---
(In reply to comment #1)
 That's word wrapping of your browser view.

It's still an issue, even if not a ddoc issue. I'm retagging it as a website issue. The documentation should look nice regardless of the browser you're using. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #3 from Kenji Hara <k.hara.pg gmail.com> 2014-02-16 03:07:56 PST ---
(In reply to comment #2)
 (In reply to comment #1)
 That's word wrapping of your browser view.

It's still an issue, even if not a ddoc issue. I'm retagging it as a website issue. The documentation should look nice regardless of the browser you're using.

I'm not sure it is an issue. It might always occur with long declaration signatures. For example: /// long function signature void aLongLong_tooLongFunctionIdentifier(LongLongParameterType1 longLongParameterName1, LongLongParameterType2 longLongParameterName2, LongLongParameterType3 longLongParameterName3, ...); -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #4 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2014-02-16
04:42:25 PST ---
Created an attachment (id=1325)
test2

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #5 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2014-02-16
04:42:59 PST ---
(In reply to comment #4)
 Created an attachment (id=1325) [details]
 test2

This is what I think is a reasonable look. IOW I don't see why the excessive whitespace was added between parameters, it looks really odd in picture 1. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #6 from Kenji Hara <k.hara.pg gmail.com> 2014-02-16 05:03:46 PST ---
(In reply to comment #5)
 (In reply to comment #4)
 Created an attachment (id=1325) [details] [details]
 test2

This is what I think is a reasonable look. IOW I don't see why the excessive whitespace was added between parameters, it looks really odd in picture 1.

So it's style issue. It will be fixed by: dlang.org/css/style.css .d_decl { font-weight: bold; background-color: #E4E9EF; /* border-top: solid black 1px; */ border-bottom: solid 2px #336600; padding: 2px 0px 2px 2px; text-align: left; // <---- added } -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrei erdani.com,
                   |                            |andrej.mitrovich gmail.com


--- Comment #7 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2014-02-16
05:16:49 PST ---
(In reply to comment #6)
 So it's style issue. It will be fixed by:
 
 dlang.org/css/style.css
 
 .d_decl {
     font-weight: bold;
     background-color: #E4E9EF;
     /* border-top: solid black 1px; */
     border-bottom: solid 2px #336600;
     padding: 2px 0px 2px 2px;
     text-align: left;   // <---- added
 }

Thanks. As long as others agree they want this we could make the change. I don't want to impose my style over anyone elses. CC'ing Andrei. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #8 from Andrei Alexandrescu <andrei erdani.com> 2014-02-16 07:31:35
PST ---
Yes, that text should not be justified. I wanted to fix that since forever but
didn't get to it. Could you please submit a pull request?

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Kenji Hara <k.hara.pg gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull


--- Comment #9 from Kenji Hara <k.hara.pg gmail.com> 2014-02-16 15:37:07 PST ---
https://github.com/D-Programming-Language/dlang.org/pull/501

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #10 from github-bugzilla puremagic.com 2014-02-16 16:46:29 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/dlang.org

https://github.com/D-Programming-Language/dlang.org/commit/7bb40822806a28f6d46c4906d4200decf45ccfe7
fix Issue 12178 - Odd whitespace look on dlang website

https://github.com/D-Programming-Language/dlang.org/commit/b5d8cfca09696cbb0477621322ced83566c1094f
Merge pull request #501 from 9rnsr/fix12178

Issue 12178 - Odd whitespace look on dlang website

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178


Andrei Alexandrescu <andrei erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 16 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #11 from github-bugzilla puremagic.com 2014-02-23 01:11:10 PST ---
Commit pushed to 2.065 at https://github.com/D-Programming-Language/dlang.org

https://github.com/D-Programming-Language/dlang.org/commit/40ca19804e8899934aa3dd0a01e169916784ceb2
Merge pull request #501 from 9rnsr/fix12178

Issue 12178 - Odd whitespace look on dlang website

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 23 2014
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12178



--- Comment #12 from github-bugzilla puremagic.com 2014-02-23 22:09:29 PST ---
Commit pushed to master at https://github.com/D-Programming-Language/dlang.org

https://github.com/D-Programming-Language/dlang.org/commit/40ca19804e8899934aa3dd0a01e169916784ceb2
Merge pull request #501 from 9rnsr/fix12178

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 23 2014