www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 12121] New: atomicLoad!(MemoryOrder.acq) should not emit additional code on X86

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12121

           Summary: atomicLoad!(MemoryOrder.acq) should not emit
                    additional code on X86
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: druntime
        AssignedTo: nobody puremagic.com
        ReportedBy: stanislav.blinov gmail.com


--- Comment #0 from Stanislav Blinov <stanislav.blinov gmail.com> 2014-02-09
10:49:48 PST ---
Current implementation of needsLoadBarrier in core.atomic is as follows:

        template needsLoadBarrier( MemoryOrder ms )
        {
            enum bool needsLoadBarrier = ms != MemoryOrder.raw;
        }

On X86, acquire loads should not require fences, release-acquire ordering is
automatic.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 09 2014
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12121


Martin Nowak <code dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code dawg.eu


--- Comment #1 from Martin Nowak <code dawg.eu> 2014-02-12 18:10:50 PST ---
As discussed here.
http://forum.dlang.org/post/yrysgcclkpeykoefkgev forum.dlang.org

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 12 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12121



--- Comment #2 from Martin Nowak <code dawg.eu> 2014-02-12 18:12:03 PST ---
https://github.com/D-Programming-Language/druntime/pull/723

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 12 2014
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12121



--- Comment #3 from github-bugzilla puremagic.com 2014-02-15 15:40:42 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/druntime

https://github.com/D-Programming-Language/druntime/commit/391573925590cf042d1d10345b0ec39699ccd48a
fix Issue 12121 - atomicLoad!(MemoryOrder.acq) doesn't require load barrier

[Issue 12121 – atomicLoad!(MemoryOrder.acq) should not emit additional code on
X86](https://d.puremagic.com/issues/show_bug.cgi?id=12121)

https://github.com/D-Programming-Language/druntime/commit/9a8a09d6746181350021b06107515013ef2a25ce
Merge pull request #723 from MartinNowak/fix12121

fix Issue 12121 - atomicLoad!(MemoryOrder.acq) doesn't require load barrier

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 15 2014
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=12121


Stanislav Blinov <stanislav.blinov gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Feb 15 2014