www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 11831] New: std.zip no longer allows setting madeVersion field in zip file

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11831

           Summary: std.zip no longer allows setting madeVersion field in
                    zip file
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Phobos
        AssignedTo: nobody puremagic.com
        ReportedBy: bugzilla digitalmars.com


--- Comment #0 from Walter Bright <bugzilla digitalmars.com> 2013-12-27
11:54:21 PST ---
std.zip needs to allow access to all fields in zip file's data structures. The
data structures written to disk should not have inaccessible private fields.

This regression blocks compilation of the chmodzip tool, which needs to be able
to set madeVersion because Linux unzippers look for specific version numbers
there.

https://github.com/D-Programming-Language/tools/pull/61

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 27 2013
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11831



--- Comment #1 from Walter Bright <bugzilla digitalmars.com> 2013-12-27
15:59:12 PST ---
Currently blocking:

https://github.com/D-Programming-Language/tools/pull/97

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 27 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11831


Martin Nowak <code dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
                 CC|                            |code dawg.eu


--- Comment #2 from Martin Nowak <code dawg.eu> 2013-12-27 17:56:15 PST ---
https://github.com/D-Programming-Language/phobos/pull/1817

(In reply to comment #0)
 std.zip needs to allow access to all fields in zip file's data structures. The
 data structures written to disk should not have inaccessible private fields.

The fact that std.zip is barely unusable and that most of it's members are undocumented should tell you a different story. madeVersion was explicitly documented as read only field btw. http://dlang.org/phobos/std_zip.html#.ArchiveMember.madeVersion
 This regression blocks compilation of the chmodzip tool, which needs to be able
 to set madeVersion because Linux unzippers look for specific version numbers
 there.

The set version number (20) works fine, it's 0x0300 in the upper byte which needs to be set for Unix format file attribute. https://github.com/D-Programming-Language/phobos/blob/e37d30fb10b94f8a3ac9013d92c7be661e52eb6b/std/zip.d#L136 -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Dec 27 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11831



--- Comment #3 from github-bugzilla puremagic.com 2013-12-27 19:38:58 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/eac5ec14d2ff8ce7c666edaea0607bd01733364a
fix Issue 11831 - std.zip no longer allows setting madeVersion field

- add deprecated ref accessor

https://github.com/D-Programming-Language/phobos/commit/8c570a0b1f210601360eb7a594863a85fddca971
Merge pull request #1817 from MartinNowak/fix11831

fix Issue 11831 - std.zip no longer allows setting madeVersion field

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 27 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11831


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 28 2013
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11831



--- Comment #4 from github-bugzilla puremagic.com 2014-01-02 09:37:34 PST ---
Commit pushed to 2.065 at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/a087fcb2c39ae13e8a0c3eb2494adae15683c6ee
fix Issue 11831 - std.zip no longer allows setting madeVersion field

- add deprecated ref accessor

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jan 02 2014