www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 11546] New: string import dependency failure

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546

           Summary: string import dependency failure
           Product: D
           Version: D2
          Platform: All
        OS/Version: Windows
            Status: NEW
          Severity: major
          Priority: P2
         Component: VisualD
        AssignedTo: nobody puremagic.com
        ReportedBy: turkeyman gmail.com


--- Comment #0 from Manu <turkeyman gmail.com> 2013-11-18 20:29:51 PST ---
vibe.d uses string imports to support it's 'diet' template system.
The problem is, changing a .dt should cause a rebuild of the app, but the
dependency is not realised and, visuald just claims "up to date".

This is very annoying. How much trouble is it to make sure build dependencies
properly account for string import?

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 18 2013
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546


Rainer Schuetze <r.sagitario gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.sagitario gmx.de


--- Comment #1 from Rainer Schuetze <r.sagitario gmx.de> 2013-11-19 00:21:42
PST ---
The problem is that they are not written into the -deps dependency file by dmd.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 19 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546



--- Comment #2 from Manu <turkeyman gmail.com> 2013-11-19 02:59:32 PST ---
Really?
I have a recollection of reading that string imports were added to the deps at
some point...

Found it. 2.064 seems to have added it: http://dlang.org/changelog.html (search
for string import)

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 19 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546



--- Comment #3 from Rainer Schuetze <r.sagitario gmx.de> 2013-11-19 11:05:22
PST ---
(In reply to comment #2)
 Really?
 I have a recollection of reading that string imports were added to the deps at
 some point...
 
 Found it. 2.064 seems to have added it: http://dlang.org/changelog.html (search
 for string import)
Unfortunately this is only for the nonsense (IMO) option to print to stdout, not to the dependency file. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Nov 19 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546



--- Comment #4 from Manu <turkeyman gmail.com> 2013-11-19 17:40:34 PST ---
(In reply to comment #3)
 (In reply to comment #2)
 Really?
 I have a recollection of reading that string imports were added to the deps at
 some point...
 
 Found it. 2.064 seems to have added it: http://dlang.org/changelog.html (search
 for string import)
Unfortunately this is only for the nonsense (IMO) option to print to stdout, not to the dependency file.
...wow. That just makes no sense. Why the inconsistency? -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Nov 19 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546


Rainer Schuetze <r.sagitario gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull


--- Comment #5 from Rainer Schuetze <r.sagitario gmx.de> 2013-11-20 00:28:48
PST ---
dmd side of the fix: https://github.com/D-Programming-Language/dmd/pull/2835

...wow.
That just makes no sense. Why the inconsistency?
The stdout version also writes some other stuff, like used version/debug identifiers and pragma(lib) entries. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Nov 20 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546



--- Comment #6 from github-bugzilla puremagic.com 2013-11-21 13:54:41 PST ---
Commit pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/57f34b2abe1693f446d6856d480515c839476b0f
Merge pull request #2835 from rainers/string_import_deps

fix  Issue 11546 - string import dependency failure

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 21 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla digitalmars.com
          Component|VisualD                     |DMD
         OS/Version|Windows                     |All
           Severity|major                       |enhancement


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 21 2013
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11546


yebblies <yebblies gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |yebblies gmail.com
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 21 2013