www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 11512] New: Regression (2.065 git-head): Can't build Phobos docs with win32 makefile

reply d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512

           Summary: Regression (2.065 git-head): Can't build Phobos docs
                    with win32 makefile
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Phobos
        AssignedTo: nobody puremagic.com
        ReportedBy: andrej.mitrovich gmail.com


--- Comment #0 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-11-13
10:56:54 PST ---
C:\dmd-git\dmd2\src\phobos>make -f win32.mak HTML
Error: don't know how to make './std.ddoc'

Worked fine a while ago, but not anymore. The 2.064.2 release works fine too.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Nov 13 2013
next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512



--- Comment #1 from Kenji Hara <k.hara.pg gmail.com> 2013-12-05 00:29:35 PST ---
I'm not sure this is a regression in git-head.

https://github.com/D-Programming-Language/phobos/commit/40854fd7e20af1749a2d7a048c263caf2209d538

std.ddoc file has been removed from 3 years ago, but release package (eg.
2.064.2.zip) contains std.ddoc in src/phobos directory.

If you want to create Phobos document in your local, you need to specify the
path to the dlang.org repo.

C:\dmd2\src\phobos> make -f win32.mak html DOCSRC=../dlang.org

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 05 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512



--- Comment #2 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-12-05
03:55:29 PST ---
(In reply to comment #1)
 I'm not sure this is a regression in git-head.
Well it definitely stopped working even though I didn't change any of my paths.
 std.ddoc file has been removed from 3 years ago, but release package (eg.
 2.064.2.zip) contains std.ddoc in src/phobos directory.
 
 If you want to create Phobos document in your local, you need to specify the
 path to the dlang.org repo.
 
 C:\dmd2\src\phobos> make -f win32.mak html DOCSRC=../dlang.org
That works, thanks. But I think this should be documented somewhere, maybe in the readme file. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Dec 05 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512


Brad Roberts <braddr puremagic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |braddr puremagic.com


--- Comment #3 from Brad Roberts <braddr puremagic.com> 2013-12-05 11:56:50 PST
---
Doesn't that strongly suggest that the default value for DOCSRC is wrong and
should be changed in the make files?

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 05 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512


Kenji Hara <k.hara.pg gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
            Summary|Regression (2.065           |Can't build Phobos docs
                   |git-head): Can't build      |with win32 makefile
                   |Phobos docs with win32      |
                   |makefile                    |
           Severity|regression                  |major


--- Comment #4 from Kenji Hara <k.hara.pg gmail.com> 2013-12-09 19:40:24 PST ---
This is not a regression, so I change the importance to "major".

(In reply to comment #3)
 Doesn't that strongly suggest that the default value for DOCSRC is wrong and
 should be changed in the make files?
https://github.com/D-Programming-Language/phobos/pull/1761 -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Dec 09 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512


Brad Roberts <braddr puremagic.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |regression


--- Comment #5 from Brad Roberts <braddr puremagic.com> 2013-12-09 21:07:40 PST
---
In what way is it not a regression.  Before a change was made, something
worked.  After the change, it no longer worked.  That's the very definition of
a regression.  Changing back.

Anyway, I never build the docs, so Andrej if you can confirm that the pull
works for you we can get this merged and move on.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 09 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512



--- Comment #6 from Kenji Hara <k.hara.pg gmail.com> 2013-12-09 21:28:36 PST ---
(In reply to comment #5)
 In what way is it not a regression.  Before a change was made, something
 worked.  After the change, it no longer worked.  That's the very definition of
 a regression.  Changing back.
 
 Anyway, I never build the docs, so Andrej if you can confirm that the pull
 works for you we can get this merged and move on.
Because the few changes for the phobos win32.mak file in least 6 months didn't touch DOCSRC variable definition. So I couldn't think that Andrej's DOCSRC issue is a regression of git-head. -- Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------
Dec 09 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512



--- Comment #7 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-12-10
02:27:48 PST ---
The new pull request fixes this, thanks Kenji.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 10 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512



--- Comment #8 from github-bugzilla puremagic.com 2013-12-10 03:09:52 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/0070d34b0312ce712aadf68580ad289da0f2d05c
fix Issue 11512 - Can't build Phobos docs with win32 makefile

Change default value of DOCSRC to ../dlang.org

https://github.com/D-Programming-Language/phobos/commit/0efad49b561442d93ce8938fa962de89da9b39c1
Merge pull request #1761 from 9rnsr/fix11512

Issue 11512 - Can't build Phobos docs with win32 makefile

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 10 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 10 2013
prev sibling parent d-bugmail puremagic.com writes:
https://d.puremagic.com/issues/show_bug.cgi?id=11512



--- Comment #9 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-12-10
03:54:31 PST ---
Of course the bottom line issue is having multiple makefiles. It's like using a
language without generics.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Dec 10 2013