www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 10869] New: Methods are marked with "const" twice

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10869

           Summary: Methods are marked with "const" twice
           Product: D
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: doob me.com


--- Comment #0 from Jacob Carlborg <doob me.com> 2013-08-22 09:26:14 PDT ---
In std.xml all methods that are const are marked with "const" twice.

http://dlang.org/phobos/std_xml.html

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 22 2013
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10869


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrej.mitrovich gmail.com


--- Comment #1 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-08-22
09:39:11 PDT ---
Introduced by f5f71ce1f50f2c33240475c44376cf176b75217e by fixing Issue 3445.

prefix is first called in declarationToDocBuffer, which adds one or more of
these:

deprecated
static
final
abstract
const
immutable
synchronized

But then toCBufferWithAttributes for functions is called which adds one or more
of these when it calls MODtoBuffer:

immutable
shared
const
inout

So there's a bit of an overlap.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 22 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10869


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ddoc, pull
            Version|unspecified                 |D2
         AssignedTo|nobody puremagic.com        |andrej.mitrovich gmail.com


--- Comment #2 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-08-22
10:05:17 PDT ---
https://github.com/D-Programming-Language/dmd/pull/2494

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 22 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10869



--- Comment #3 from Andrej Mitrovic <andrej.mitrovich gmail.com> 2013-08-22
10:06:29 PDT ---
There's another problem, synchronized methods were usually handled in the
prefix function, which output "synchronized", but then MODtoBuffer in
toCBufferWithAttributes outputs "shared". So I'll file this as another bug once
this pull is merged first.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 22 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10869



--- Comment #4 from github-bugzilla puremagic.com 2013-08-26 14:26:31 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/da91b6da998793a66f89d58343beb44e5f0889bf
Fixes Issue 10869 - Ddoc outputted some function modifiers twice.

https://github.com/D-Programming-Language/dmd/commit/08d621c232260b231b7a3a4f326f8d4441d22b80
Merge pull request #2494 from AndrejMitrovic/Fix10869

Issue 10869 - Ddoc outputted some function modifiers twice.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 26 2013
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10869


Walter Bright <bugzilla digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |bugzilla digitalmars.com
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Aug 26 2013