www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 10688] New: Misleading error message when attempting a "private override"

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10688

           Summary: Misleading error message when attempting a "private
                    override"
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: DMD
        AssignedTo: nobody puremagic.com
        ReportedBy: Marco.Leise gmx.de


--- Comment #0 from Marco Leise <Marco.Leise gmx.de> 2013-07-21 02:18:29 PDT ---
class Bar: Foo {
private:
    override void func() {}
}

This doesn't compile and print "cannot override a non-virtual function". It
took me a while to realize that the problem (in a larger class) was not in the
base class, but in the attributes of the override.

What about error messages like:
"cannot reduce visibility of override" or
"overrides must not be private"

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 21 2013
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10688


Henning Pohl <henning still-hidden.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |henning still-hidden.de


--- Comment #1 from Henning Pohl <henning still-hidden.de> 2013-07-24 04:14:44
PDT ---
https://github.com/D-Programming-Language/dmd/pull/2376

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 24 2013
prev sibling next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10688



--- Comment #2 from github-bugzilla puremagic.com 2013-07-25 12:37:10 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/6663240705598be8ffb16d2b2a88da7246bcd599
fix issue 10688 - Misleading error message when attempting a "private
override"

https://github.com/D-Programming-Language/dmd/commit/e0e73f6198f0e1cb5344d67f842ba9b74ec9ff6a
Merge pull request #2376 from hpohl/10688

[enh] fix issue 10688 - Misleading error message when attempting a "private
override"

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 25 2013
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10688


Andrej Mitrovic <andrej.mitrovich gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |andrej.mitrovich gmail.com
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
Jul 25 2013