www.digitalmars.com         C & C++   DMDScript  

digitalmars.D.bugs - [Issue 10182] New: std.bitmanip unit test has pointless/unused foreach loop

reply d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10182

           Summary: std.bitmanip unit test has pointless/unused foreach
                    loop
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Phobos
        AssignedTo: nobody puremagic.com
        ReportedBy: diggsey googlemail.com


--- Comment #0 from Diggory <diggsey googlemail.com> 2013-05-27 00:42:40 PDT ---
Extremely minor issue but w/e

std.bitmanip contains the code:

unittest {
    foreach(endianness; TypeTuple!(Endian.bigEndian, Endian.littleEndian))
    {
       ... // Unit test code
    }
}

But then makes no reference to "endianness" in the actual code. The loop should
either be removed or the code updated to test both endiannesses if that's
possible.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 27 2013
next sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10182



--- Comment #1 from Diggory <diggsey googlemail.com> 2013-05-27 03:44:37 PDT ---
https://github.com/D-Programming-Language/phobos/pull/1310

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 27 2013
prev sibling parent d-bugmail puremagic.com writes:
http://d.puremagic.com/issues/show_bug.cgi?id=10182


Diggory <diggsey googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
May 27 2013