www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Why doesn't dlang-bot use the GitHub conventions?

reply Jacob Carlborg <doob me.com> writes:
Apparently dlang-bot doesn't recognize the GitHub syntax/conventions [1] 
to link and close issues from pull requests. Instead one have to use 
"Fix issue ...". I don't see a point in inventing new conventions for this.

Can we please have dlang-bot recognize the GitHub syntax as well?

[1] https://help.github.com/articles/closing-issues-via-commit-messages/

-- 
/Jacob Carlborg
May 18 2016
next sibling parent reply Daniel Murphy <yebbliesnospam gmail.com> writes:
On 19/05/2016 12:27 AM, Jacob Carlborg wrote:
 Apparently dlang-bot doesn't recognize the GitHub syntax/conventions [1]
 to link and close issues from pull requests. Instead one have to use
 "Fix issue ...". I don't see a point in inventing new conventions for this.

 Can we please have dlang-bot recognize the GitHub syntax as well?

 [1] https://help.github.com/articles/closing-issues-via-commit-messages/
No, because #99 is a github pull request reference.
May 18 2016
parent reply Jacob Carlborg <doob me.com> writes:
On 2016-05-18 17:05, Daniel Murphy wrote:

 No, because #99 is a github pull request reference.
GitHub uses the same syntax to refer to issues and pull requests. If the syntax works for GitHub I don't see why it can't work for us. No point in inventing a new syntax when a lot of developers are already familiar with the GitHub syntax. -- /Jacob Carlborg
May 18 2016
parent Daniel Murphy <yebbliesnospam gmail.com> writes:
On 19/05/2016 3:06 AM, Jacob Carlborg wrote:
 On 2016-05-18 17:05, Daniel Murphy wrote:

 No, because #99 is a github pull request reference.
GitHub uses the same syntax to refer to issues and pull requests. If the syntax works for GitHub I don't see why it can't work for us. No point in inventing a new syntax when a lot of developers are already familiar with the GitHub syntax.
Yes, and the numbers overlap with the bugzilla issue numbers. So if I say '#3' it will think I mean https://github.com/dlang/dmd/pull/3 instead of https://issues.dlang.org/show_bug.cgi?id=3
May 18 2016
prev sibling next sibling parent reply David Nadlinger <code klickverbot.at> writes:
On Wednesday, 18 May 2016 at 14:27:22 UTC, Jacob Carlborg wrote:
 Apparently dlang-bot doesn't recognize the GitHub 
 syntax/conventions [1] to link and close issues from pull 
 requests. Instead one have to use "Fix issue ...". I don't see 
 a point in inventing new conventions for this.

 Can we please have dlang-bot recognize the GitHub syntax as 
 well?

 [1] 
 https://help.github.com/articles/closing-issues-via-commit-messages/
dlang-bot is not related to the Bugzilla integration proper. Martin wrote it to have links back to the respective issues automatically available somewhere on the PR page, but it's a separate tool. - David
May 18 2016
parent Jacob Carlborg <doob me.com> writes:
On 2016-05-18 17:32, David Nadlinger wrote:

 dlang-bot is not related to the Bugzilla integration proper. Martin
 wrote it to have links back to the respective issues automatically
 available somewhere on the PR page, but it's a separate tool.
I suspected that, not sure how is relevant though. -- /Jacob Carlborg
May 18 2016
prev sibling parent reply Martin Nowak <code dawg.eu> writes:
On Wednesday, 18 May 2016 at 14:27:22 UTC, Jacob Carlborg wrote:
 Can we please have dlang-bot recognize the GitHub syntax as 
 well?
That is actually the syntax for github's Bugzilla integration that we're using, and I don't plan on replacing that. We also rely on that for our changelog. As we're fairly Bugzilla centric it makes a lot of sense to use that as primary reference. Unnecessary to say that using the same #1234 syntax for 2 different id ranges (Bugzilla Ticket and GH PRs/Issues) is a bad idea.
Aug 07 2016
next sibling parent Martin Nowak <code dawg.eu> writes:
On Sunday, 7 August 2016 at 20:03:45 UTC, Martin Nowak wrote:
 That is actually the syntax for github's Bugzilla integration 
 that we're using, and I don't plan on replacing that. We also 
 rely on that for our changelog.
https://github.com/github/github-services/blob/2e886f407696261bd5adfc99b16d36d5e7b50241/lib/services/bugzilla.rb#L155 https://github.com/MartinNowak/dlang-bot/blob/7d2ae748c21a71517887481e30501f97af0a94f8/source/app.d#L93 https://github.com/dlang/tools/blob/e32fe5dc816a35a3a6ee4546e8107b4ae3102792/changed.d#L76
Aug 07 2016
prev sibling parent reply Martin Nowak <code dawg.eu> writes:
On Sunday, 7 August 2016 at 20:03:45 UTC, Martin Nowak wrote:

BTW, dlang-bot got a logo and it's own home page today.

[Dlang-Bot](http://dlang-bot.herokuapp.com/)

Also since yesterday it cancels outdated Travis-CI builds to 
reduce our test load.
Aug 07 2016
parent reply qznc <qznc web.de> writes:
On Sunday, 7 August 2016 at 20:08:48 UTC, Martin Nowak wrote:
 On Sunday, 7 August 2016 at 20:03:45 UTC, Martin Nowak wrote:

 BTW, dlang-bot got a logo and it's own home page today.

 [Dlang-Bot](http://dlang-bot.herokuapp.com/)

 Also since yesterday it cancels outdated Travis-CI builds to 
 reduce our test load.
That logo is actually the first D-Man I like. :)
Aug 07 2016
parent Seb <seb wilzba.ch> writes:
On Sunday, 7 August 2016 at 21:04:40 UTC, qznc wrote:
 On Sunday, 7 August 2016 at 20:08:48 UTC, Martin Nowak wrote:
 On Sunday, 7 August 2016 at 20:03:45 UTC, Martin Nowak wrote:

 BTW, dlang-bot got a logo and it's own home page today.

 [Dlang-Bot](http://dlang-bot.herokuapp.com/)

 Also since yesterday it cancels outdated Travis-CI builds to 
 reduce our test load.
That logo is actually the first D-Man I like. :)
Do you know about this collection I am trying to gather? https://github.com/wilzbach/d-mans Atm it has about 200 D-mans ;-) There is a rudimentary way to browse them online (warning - will show them all on one page): https://wilzbach.github.io/d-mans/meiz
Aug 07 2016