www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Trivial DMD fixes: GitHub pull requests vs. Bugzilla issues

reply David Nadlinger <see klickverbot.at> writes:
For almost a month now, I have a trivial pull request open for DMD: 
https://github.com/D-Programming-Language/dmd/pull/10. It's only about 
adding the word »length« in two places to clarify the tuple 
out-of-bounds error message, so I didn't bother to open a ticket for it 
because I figured that it would only create unneeded administrative 
overhead for such a small change.

However, given that the commit has not been merged yet: Walter, do you 
still prefer Bugzilla issues for this kind of patches?

David
Mar 19 2011
parent reply Jonathan M Davis <jmdavisProg gmx.com> writes:
On Saturday 19 March 2011 08:43:44 David Nadlinger wrote:
 For almost a month now, I have a trivial pull request open for DMD:
 https://github.com/D-Programming-Language/dmd/pull/10. It's only about
 adding the word =C2=BBlength=C2=AB in two places to clarify the tuple
 out-of-bounds error message, so I didn't bother to open a ticket for it
 because I figured that it would only create unneeded administrative
 overhead for such a small change.
=20
 However, given that the commit has not been merged yet: Walter, do you
 still prefer Bugzilla issues for this kind of patches?

Bugzilla is for tracking bugs. github is for tracking the source. So, in=20 general, I would expect bugs to be reported to bugzilla. I would guess tho= ugh,=20 that enhancement requests aren't quite as critical if you already have a pa= tch=20 for them (though you're likely to get a better discussion on bugzilla if yo= u=20 post enhancements there in addition to creating a pull request). However, g= iven=20 that this sounds like a very small change, it's probably fine that it's jus= t a=20 pull request - though, of courses, Walter would be better suited to say wha= t=20 Walter would prefer. Regardless, as I understand it, Walter has been a bit overwhelmed with pull= =20 requests of late (you can check out the thread on dmd-internals about it:=20 http://lists.puremagic.com/pipermail/dmd-internals/2011-March/001293.html )= , and=20 it's taking him some time to work through them. I expect that he'll get to = your=20 pull request eventually. =2D Jonathan M Davis
Mar 19 2011
parent David Nadlinger <see klickverbot.at> writes:
On 3/20/11 12:20 AM, Jonathan M Davis wrote:
 Bugzilla is for tracking bugs. github is for tracking the source. So, in
 general, I would expect bugs to be reported to bugzilla.  I would guess though,
 that enhancement requests aren't quite as critical if you already have a patch
 for them (though you're likely to get a better discussion on bugzilla if you
 post enhancements there in addition to creating a pull request). However, given
 that this sounds like a very small change, it's probably fine that it's just a
 pull request - though, of courses, Walter would be better suited to say what
 Walter would prefer.

Funny, that's actually a pretty accurate description of what I was thinking when I asked the question. ;)
 Regardless, as I understand it, Walter has been a bit overwhelmed with pull
 requests of late (you can check out the thread on dmd-internals about it:
 http://lists.puremagic.com/pipermail/dmd-internals/2011-March/001293.html ),
and
 it's taking him some time to work through them. I expect that he'll get to your
 pull request eventually.

Oh, I just noticed that I must have messed up my dmd-internals subscription somehow, not noticing it because I got the commit notifications directly via GitHub nevertheless (but wondering why it was so quiet lately) – thanks a lot! David
Mar 20 2011