www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Std.path: Final Vote

reply dsimcha <dsimcha yahoo.com> writes:
My apologies for not announcing this yesterday.  For some reason I 
thought today was the official end of review.  Anyhow, Lars 
Kyllingstad's new std.path module, which has been in review for the past 
3 weeks, is up for vote.  Please vote yes or no in this thread.

Code:
https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

Docs
http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

Voting ends next Friday, August 12, since it started a day late.
Aug 05 2011
next sibling parent dsimcha <dsimcha yahoo.com> writes:
BTW, I'll cast the first YES vote.

On 8/5/2011 9:26 AM, dsimcha wrote:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Aug 05 2011
prev sibling next sibling parent Jesse Phillips <jessekphillips+d gmail.com> writes:
On Fri, 05 Aug 2011 09:26:39 -0400, dsimcha wrote:

 My apologies for not announcing this yesterday.  For some reason I
 thought today was the official end of review.  Anyhow, Lars
 Kyllingstad's new std.path module, which has been in review for the past
 3 weeks, is up for vote.  Please vote yes or no in this thread.
 
 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d
 
 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html
 
 Voting ends next Friday, August 12, since it started a day late.

Yes
Aug 05 2011
prev sibling next sibling parent Mike Parker <aldacron gmail.com> writes:
On 8/5/2011 10:26 PM, dsimcha wrote:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes
Aug 05 2011
prev sibling next sibling parent Alix Pexton <alix.DOT.pexton gmail.DOT.com> writes:
On 05/08/2011 14:26, dsimcha wrote:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

YES!
Aug 05 2011
prev sibling next sibling parent Denis Shelomovskij <verylonglogin.reg gmail.com> writes:
05.08.2011 16:26, dsimcha пишет:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Aug 05 2011
prev sibling next sibling parent "Nick Sabalausky" <a a.a> writes:
"dsimcha" <dsimcha yahoo.com> wrote in message 
news:j1gr3g$19kp$1 digitalmars.com...
 My apologies for not announcing this yesterday.  For some reason I thought 
 today was the official end of review.  Anyhow, Lars Kyllingstad's new 
 std.path module, which has been in review for the past 3 weeks, is up for 
 vote.  Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes
Aug 05 2011
prev sibling next sibling parent =?ISO-8859-1?Q?Alex_R=F8nne_Petersen?= <xtzgzorex gmail.com> writes:
On 05-08-2011 15:26, dsimcha wrote:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes. - Alex
Aug 05 2011
prev sibling next sibling parent Paul D. Anderson <paul.d.removethis.anderson comcast.andthis.net> writes:
dsimcha Wrote:

 My apologies for not announcing this yesterday.  For some reason I 
 thought today was the official end of review.  Anyhow, Lars 
 Kyllingstad's new std.path module, which has been in review for the past 
 3 weeks, is up for vote.  Please vote yes or no in this thread.
 
 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d
 
 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html
 
 Voting ends next Friday, August 12, since it started a day late.

Yea!
Aug 05 2011
prev sibling next sibling parent Johannes Pfau <spam example.com> writes:
dsimcha wrote:
My apologies for not announcing this yesterday.  For some reason I 
thought today was the official end of review.  Anyhow, Lars 
Kyllingstad's new std.path module, which has been in review for the
past 3 weeks, is up for vote.  Please vote yes or no in this thread.

Code:
https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

Docs
http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

Voting ends next Friday, August 12, since it started a day late.

Yes -- Johannes Pfau
Aug 05 2011
prev sibling next sibling parent Andrej Mitrovic <andrej.mitrovich gmail.com> writes:
Aye! I mean Yes.
Aug 05 2011
prev sibling next sibling parent filgood <filgood somewhere.net> writes:
On 05/08/2011 14:26, dsimcha wrote:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Aug 05 2011
prev sibling next sibling parent Mike Wey <mike-wey example.com> writes:
Op 5-8-2011 15:26, dsimcha schreef:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes.
Aug 05 2011
prev sibling next sibling parent Jose Armando Garcia <jsancio gmail.com> writes:
Yes!

On Fri, Aug 5, 2011 at 2:22 PM, Mike Wey <mike-wey example.com> wrote:
 Op 5-8-2011 15:26, dsimcha schreef:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes.

Aug 05 2011
prev sibling next sibling parent Don <nospam nospam.com> writes:
dsimcha wrote:
 My apologies for not announcing this yesterday.  For some reason I 
 thought today was the official end of review.  Anyhow, Lars 
 Kyllingstad's new std.path module, which has been in review for the past 
 3 weeks, is up for vote.  Please vote yes or no in this thread.
 
 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d
 
 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html
 
 Voting ends next Friday, August 12, since it started a day late.

Aug 05 2011
prev sibling next sibling parent torhu <no spam.invalid> writes:
On 05.08.2011 15:26, dsimcha wrote:
 My apologies for not announcing this yesterday.  For some reason I
 thought today was the official end of review.  Anyhow, Lars
 Kyllingstad's new std.path module, which has been in review for the past
 3 weeks, is up for vote.  Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Aug 06 2011
prev sibling next sibling parent jdrewsen <jdrewsen nospam.com> writes:
Yes!
Aug 06 2011
prev sibling next sibling parent Jonathan M Davis <jmdavisProg gmx.com> writes:
On Friday 05 August 2011 09:26:39 dsimcha wrote:
 My apologies for not announcing this yesterday.  For some reason I
 thought today was the official end of review.  Anyhow, Lars
 Kyllingstad's new std.path module, which has been in review for the past
 3 weeks, is up for vote.  Please vote yes or no in this thread.
 
 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d
 
 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html
 
 Voting ends next Friday, August 12, since it started a day late.

Yes. I sure would love to have had those function names shortened, but it would be pretty petty to vote no over that. Other than that, it looks great! - Jonathan M Davis
Aug 06 2011
prev sibling next sibling parent reply "Lars T. Kyllingstad" <public kyllingen.NOSPAMnet> writes:
On Fri, 05 Aug 2011 09:26:39 -0400, dsimcha wrote:

 My apologies for not announcing this yesterday.  For some reason I
 thought today was the official end of review.  Anyhow, Lars
 Kyllingstad's new std.path module, which has been in review for the past
 3 weeks, is up for vote.  Please vote yes or no in this thread.
 
 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d
 
 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html
 
 Voting ends next Friday, August 12, since it started a day late.

I would just like to remind everyone that there are now only two days left until voting ends. While I am certainly pleased that everyone has so far voted "yes", I am a bit worried that so few people have voted in the first place. This module may become a permanent part of D's standard library. If you care about this, either way, please cast your vote now. -Lars
Aug 10 2011
next sibling parent "Marco Leise" <Marco.Leise gmx.de> writes:
Am 10.08.2011, 13:19 Uhr, schrieb Lars T. Kyllingstad  
<public kyllingen.nospamnet>:

 On Fri, 05 Aug 2011 09:26:39 -0400, dsimcha wrote:

 My apologies for not announcing this yesterday.  For some reason I
 thought today was the official end of review.  Anyhow, Lars
 Kyllingstad's new std.path module, which has been in review for the past
 3 weeks, is up for vote.  Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

I would just like to remind everyone that there are now only two days left until voting ends. While I am certainly pleased that everyone has so far voted "yes", I am a bit worried that so few people have voted in the first place. This module may become a permanent part of D's standard library. If you care about this, either way, please cast your vote now. -Lars

Yes, if you correct "Some characters of pattern have special a meaning" ;)
Aug 10 2011
prev sibling parent reply Russel Winder <russel russel.org.uk> writes:
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2011-08-10 at 11:19 +0000, Lars T. Kyllingstad wrote:
[ . . . ]
 I would just like to remind everyone that there are now only two days=20
 left until voting ends.  While I am certainly pleased that everyone has=

 so far voted "yes", I am a bit worried that so few people have voted in=

 the first place.
=20
 This module may become a permanent part of D's standard library.  If you=

 care about this, either way, please cast your vote now.

I suspect there are many people who have not followed the debate nor reviewed the code who are therefore taking the view that to cast a vote would be somewhat out of order. I think that as long as those people who have been active in the evaluation have cast a vote, and Walter et al. are happy that due process has been followed, then even with what appears to be a low turn out, given that it is yes, nem con, becoming part of the standard library is a sensible natural consequence. --=20 Russel. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D Dr Russel Winder t: +44 20 7585 2200 voip: sip:russel.winder ekiga.n= et 41 Buckmaster Road m: +44 7770 465 077 xmpp: russel russel.org.uk London SW11 1EN, UK w: www.russel.org.uk skype: russel_winder
Aug 10 2011
parent reply dsimcha <dsimcha yahoo.com> writes:
== Quote from Russel Winder (russel russel.org.uk)'s article
 --=-/EZ9N8/9sZ9dsJoreonX
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 On Wed, 2011-08-10 at 11:19 +0000, Lars T. Kyllingstad wrote:
 [ . . . ]
 I would just like to remind everyone that there are now only two days=20
 left until voting ends.  While I am certainly pleased that everyone has=

 so far voted "yes", I am a bit worried that so few people have voted in=

 the first place.
=20
 This module may become a permanent part of D's standard library.  If you=

 care about this, either way, please cast your vote now.

reviewed the code who are therefore taking the view that to cast a vote would be somewhat out of order. I think that as long as those people who have been active in the evaluation have cast a vote, and Walter et al. are happy that due process has been followed, then even with what appears to be a low turn out, given that it is yes, nem con, becoming part of the standard library is a sensible natural consequence.

Yeah. IMHO, the voting process is mostly a formality, though a necessary one. If a module makes it to a vote, it's probably going to be overwhelmingly accepted, but that's because the process serves as an effective deterrent to crappy code making it to a vote, not because the vote isn't serving any useful purpose. It's kind of like Ph.D. thesis defenses in the U.S. Almost noone ever fails, but that's because noone ever defends their thesis until they're almost sure it would pass, not because the defense process is a useless rubber stamp.
Aug 10 2011
parent Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 8/10/11 9:46 AM, dsimcha wrote:
 == Quote from Russel Winder (russel russel.org.uk)'s article
 --=-/EZ9N8/9sZ9dsJoreonX
 Content-Type: text/plain; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable
 On Wed, 2011-08-10 at 11:19 +0000, Lars T. Kyllingstad wrote:
 [ . . . ]
 I would just like to remind everyone that there are now only two days=20
 left until voting ends.  While I am certainly pleased that everyone has=

 so far voted "yes", I am a bit worried that so few people have voted in=

 the first place.
 =20
 This module may become a permanent part of D's standard library.  If you=

 care about this, either way, please cast your vote now.

reviewed the code who are therefore taking the view that to cast a vote would be somewhat out of order. I think that as long as those people who have been active in the evaluation have cast a vote, and Walter et al. are happy that due process has been followed, then even with what appears to be a low turn out, given that it is yes, nem con, becoming part of the standard library is a sensible natural consequence.

Yeah. IMHO, the voting process is mostly a formality, though a necessary one. If a module makes it to a vote, it's probably going to be overwhelmingly accepted, but that's because the process serves as an effective deterrent to crappy code making it to a vote, not because the vote isn't serving any useful purpose. It's kind of like Ph.D. thesis defenses in the U.S. Almost noone ever fails, but that's because noone ever defends their thesis until they're almost sure it would pass, not because the defense process is a useless rubber stamp.

That makes horror stories of failed defenses all the more horrifying :o). Apologies for not voting. I'm not able to put time into a review now, but I'm confident that the process has shaken any major issues I might have had with the module. We've come a long way in terms of community and process. Andrei
Aug 10 2011
prev sibling next sibling parent "Masahiro Nakagawa" <repeatedly gmail.com> writes:
On Fri, 05 Aug 2011 22:26:39 +0900, dsimcha <dsimcha yahoo.com> wrote:

 My apologies for not announcing this yesterday.  For some reason I  
 thought today was the official end of review.  Anyhow, Lars  
 Kyllingstad's new std.path module, which has been in review for the past  
 3 weeks, is up for vote.  Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes!!
Aug 10 2011
prev sibling next sibling parent "Vladimir Panteleev" <vladimir thecybershadow.net> writes:
On Fri, 05 Aug 2011 16:26:39 +0300, dsimcha <dsimcha yahoo.com> wrote:

 My apologies for not announcing this yesterday.  For some reason I  
 thought today was the official end of review.  Anyhow, Lars  
 Kyllingstad's new std.path module, which has been in review for the past  
 3 weeks, is up for vote.  Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

Yes! -- Best regards, Vladimir mailto:vladimir thecybershadow.net
Aug 10 2011
prev sibling next sibling parent Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 8/5/11 7:26 AM, dsimcha wrote:
 My apologies for not announcing this yesterday. For some reason I
 thought today was the official end of review. Anyhow, Lars Kyllingstad's
 new std.path module, which has been in review for the past 3 weeks, is
 up for vote. Please vote yes or no in this thread.

 Code:
 https://github.com/kyllingstad/phobos/blob/std-path/std/path.d

 Docs
 http://www.kyllingen.net/code/std-path/phobos-prerelease/std_path.html

 Voting ends next Friday, August 12, since it started a day late.

My vote is "yes", with a few advisory comments. Comments on the documentation: * "This module is used to parse path strings." -> "This module is used to manipulate path strings." * "perform any I/O" -> "perform any actual file system actions" * "use std.file.isDir and std.file.exists" -> use the XREF macro to generate cross-reference links. * "backslashes on this platform" -> "backslashes on that platform" * "The result of calling a function on an ill-formed path is undefined." This simplifies documentation but is a bit extreme. We could and should specify the behavior for strings that don't look quite like paths. * BTW we should have a validPath() function that tells whether a string looks like a valid path or not. * Add example: assert (baseName("dir/file.ext", ".xyz") == "file.ext"); * defaultExtension -> setDefaultExtension? * absolutePath calls getcwd(), negating the assertion in the beginning that there's no real directory access going on. * absolutePath and others use string, others use generic characters. Why? (This is my strongest comment.) * filenameCharCmp and filenameCmp -> why long and not int? * Example in expandTilde uses odd ALL_UPERCASE variable names. Comments on the implementation: * We're increasingly moving towards consolidating imports into one. * "." is hardcoded as a symbol for the current dir. * Would be interesting to figure what it would take to make pathSplitter reuse splitter. * Misalignment in lines 2195--2238. I think you don't need the extra scope there anyway, but if you do, don't make a special rule for that case - obey normal brace indentation. Andrei
Aug 10 2011
prev sibling parent Rainer Schuetze <r.sagitario gmx.de> writes:
Yes
Aug 12 2011