www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - Procedural Question for Pull Requests

reply "Adam Wilson" <flyboynw gmail.com> writes:
Hi everyone,

I have a small procedural question regarding pull requests against  
druntime's operating system interfaces. Specifically I may find it quite  
useful to add Windows API function calls and types to the  
core.sys.windows.windows file.

Should I pull them as needed or bunch them up and do a larger pull later?

-- 
Adam Wilson
GitHub/IRC: LightBender
Aurora Project Coordinator
May 26 2014
next sibling parent reply "Daniel Murphy" <yebbliesnospam gmail.com> writes:
"Adam Wilson"  wrote in message news:op.xghyetkm707hn8 invictus.hra.local...

 Hi everyone,

 I have a small procedural question regarding pull requests against 
 druntime's operating system interfaces. Specifically I may find it quite 
 useful to add Windows API function calls and types to the 
 core.sys.windows.windows file.

 Should I pull them as needed or bunch them up and do a larger pull later?

As needed, as small as possible.
May 26 2014
parent Walter Bright <newshound2 digitalmars.com> writes:
On 5/26/2014 8:14 PM, Daniel Murphy wrote:
 As needed, as small as possible.

Right. The smaller they are, the easier they are to review.
May 26 2014
prev sibling parent "Adam Wilson" <flyboynw gmail.com> writes:
On Mon, 26 May 2014 21:20:09 -0700, Walter Bright  
<newshound2 digitalmars.com> wrote:

 On 5/26/2014 8:14 PM, Daniel Murphy wrote:
 As needed, as small as possible.

Right. The smaller they are, the easier they are to review.

Done. I look forward to some easy stats karma then. ;-) -- Adam Wilson GitHub/IRC: LightBender Aurora Project Coordinator
May 26 2014