www.digitalmars.com         C & C++   DMDScript  

digitalmars.D - [OT] google- and github-fu: how to search for a specific PR?

reply Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
I was looking for the PR that changed iota.length and it took me longer 
than it could have. I googled for

iota length dlang

and among the top results I found the changelog PR: 
https://github.com/dlang/phobos/pull/4220, but it was through 
indirections via mail-archive.com. Same goes about the actual result 
(https://github.com/dlang/phobos/pull/4013) which was further down the 
page.

Are there any shortcuts? It would help a lot if one could search 
github.com repos for PR titles, is that possible?


Thanks,

Andrei
Oct 01 2016
next sibling parent Dicebot <public dicebot.lv> writes:
 protected-headers="v1"
From: Dicebot <public dicebot.lv>
Newsgroups: d,i,g,i,t,a,l,m,a,r,s,.,D
Subject: Re: [OT] google- and github-fu: how to search for a specific PR?
References: <nsoaea$2lbp$1 digitalmars.com>
In-Reply-To: <nsoaea$2lbp$1 digitalmars.com>

--idkwNGQX0cSdrBKu02SVGRtpwkB4OGTAE
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 10/01/2016 03:33 PM, Andrei Alexandrescu wrote:
 I was looking for the PR that changed iota.length and it took me longer=
 than it could have. I googled for
=20
 iota length dlang
=20
 and among the top results I found the changelog PR:
 https://github.com/dlang/phobos/pull/4220, but it was through
 indirections via mail-archive.com. Same goes about the actual result
 (https://github.com/dlang/phobos/pull/4013) which was further down the
 page.
=20
 Are there any shortcuts? It would help a lot if one could search
 github.com repos for PR titles, is that possible?
=20
=20
 Thanks,
=20
 Andrei
https://github.com/search?q=3Diota+length+dlang+&type=3DIssues&utf8=3D%E2= %9C%93 Is that good enough? Relevant PR is the second entry there for me. --idkwNGQX0cSdrBKu02SVGRtpwkB4OGTAE--
Oct 01 2016
prev sibling next sibling parent rikki cattermole <rikki cattermole.co.nz> writes:
On 02/10/2016 1:33 AM, Andrei Alexandrescu wrote:
 I was looking for the PR that changed iota.length and it took me longer
 than it could have. I googled for

 iota length dlang

 and among the top results I found the changelog PR:
 https://github.com/dlang/phobos/pull/4220, but it was through
 indirections via mail-archive.com. Same goes about the actual result
 (https://github.com/dlang/phobos/pull/4013) which was further down the
 page.

 Are there any shortcuts? It would help a lot if one could search
 github.com repos for PR titles, is that possible?


 Thanks,

 Andrei
https://github.com/dlang/phobos/search?utf8=%E2%9C%93&q=iota+length&type=Issues If we used more labels it would be easier still. This is also where integrated bug tracker can help significantly since its a commit message like "Fixes #1" would auto close issue once merged[0] and have it mentioned in both places. [0] https://help.github.com/articles/closing-issues-via-commit-messages/
Oct 01 2016
prev sibling next sibling parent Ilya Yaroshenko <ilyayaroshenko gmail.com> writes:
On Saturday, 1 October 2016 at 12:33:14 UTC, Andrei Alexandrescu 
wrote:
 I was looking for the PR that changed iota.length and it took 
 me longer than it could have. I googled for
 Thanks,

 Andrei
See also https://github.com/dlang/phobos/pull/4167
Oct 01 2016
prev sibling parent reply Vladimir Panteleev <thecybershadow.lists gmail.com> writes:
On Saturday, 1 October 2016 at 12:33:14 UTC, Andrei Alexandrescu 
wrote:
 Are there any shortcuts?
Since the other answers have the fish, so I'll throw in (another) fishing rod: 1. Use `git blame` to find the commit you wish to find the PR of. (Since you use Emacs, magit's magit-blame is fantastic as always). 2. Concatenate "https://github.com/dlang/phobos/commit/" and the commit SHA1 to get the GitHub commit URL. 3. Click the pull request number below the commit message: https://dump.thecybershadow.net/9c86005610bf869873385d7ca6a76ee6/23%3A10%3A46-upload.png
Oct 01 2016
parent Andrei Alexandrescu <SeeWebsiteForEmail erdani.org> writes:
On 10/01/2016 07:15 PM, Vladimir Panteleev wrote:
 On Saturday, 1 October 2016 at 12:33:14 UTC, Andrei Alexandrescu wrote:
 Are there any shortcuts?
Since the other answers have the fish, so I'll throw in (another) fishing rod: 1. Use `git blame` to find the commit you wish to find the PR of. (Since you use Emacs, magit's magit-blame is fantastic as always). 2. Concatenate "https://github.com/dlang/phobos/commit/" and the commit SHA1 to get the GitHub commit URL. 3. Click the pull request number below the commit message: https://dump.thecybershadow.net/9c86005610bf869873385d7ca6a76ee6/23%3A10%3A46-upload.png
Thx to all! -- Andrei
Oct 01 2016